Add Tools section to MCP server details page #2371
Add Tools section to MCP server details page #2371google-oss-prow[bot] merged 7 commits intokubeflow:mainfrom
Conversation
manaswinidas
force-pushed
the
tools-mcp-details
branch
from
2b96e75 to
fb2c9da
Compare
|
/unhold |
|
/retest |
| }; | ||
|
|
||
| const toolsCardShell = (children: React.ReactNode) => ( | ||
| <Card data-testid="mcp-server-tools" style={{ overflow: 'visible' }}> |
There was a problem hiding this comment.
I see that we have test-ids being added - but missing cypress tests
| </Card> | ||
| </StackItem> | ||
| <StackItem> | ||
| <McpServerToolsSection serverId={String(server.id)} /> |
There was a problem hiding this comment.
server.id should be a string - could you please update the types?
| Required: false, | ||
| }, | ||
| }, | ||
| Revoked: &falseVal, |
There was a problem hiding this comment.
Can we have a one tool with Revoked as True? I am not sure how will it affect the UI because we never used that field
manaswinidas
force-pushed
the
tools-mcp-details
branch
from
fb2c9da to
38a9392
Compare
|
/retest |
Signed-off-by: manaswinidas <[email protected]>
Signed-off-by: manaswinidas <[email protected]>
Signed-off-by: manaswinidas <[email protected]>
Signed-off-by: manaswinidas <[email protected]>
Signed-off-by: manaswinidas <[email protected]>
Signed-off-by: manaswinidas <[email protected]>
manaswinidas
force-pushed
the
tools-mcp-details
branch
from
b3c7245 to
afffd20
Compare
| @@ -9,7 +9,7 @@ import { MCP_CATALOG_GALLERY } from '~/app/pages/mcpCatalog/const'; | |||
| import McpCatalogGalleryView from '~/app/pages/mcpCatalog/screens/McpCatalogGalleryView'; | |||
|
|
|||
| const buildServer = (id: number, sourceId: string): McpServer => ({ | |||
There was a problem hiding this comment.
just a minor one: can we just pass id: string here instead of converting later?
Signed-off-by: manaswinidas <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Description
Screen.Recording.2026-03-11.at.4.30.23.PM.mov
Still uses mocks introduced by #2314 - which will be removed by #2362 - will add the empty/loading/error states accordingly
/hold until #2362 merges
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes