Skip to content

[feature] pull image from ghcr in manifest #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −7
Open

[feature] pull image from ghcr in manifest #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a790d5e
pull image from ghcr in manifest
mahdikhashan Apr 14, 2025
d2ae7e0
replace docker with ghcr in makefile
mahdikhashan Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ LD_FLAGS_V2=" \
-X '${REPO_PATH}/pkg/version.GitSHA=${GitSHA}' \
-X '${REPO_PATH}/pkg/version.Built=${Date}' \
-X '${REPO_PATH}/pkg/version.Version=${RELEASE_VERSION}'"
REGISTRY?=docker.io/mpioperator
IMAGE_NAME?=${REGISTRY}/mpi-operator
REGISTRY?=ghcr.io/kubeflow/mpi-operator
IMAGE_NAME?=${REGISTRY}/controller
KUBEBUILDER_ASSETS_PATH := $(dir $(abspath $(firstword $(MAKEFILE_LIST))))bin/kubebuilder/bin
KIND_VERSION=v0.18.0
HELM_VERSION=v3.11.2
Expand Down
2 changes: 1 addition & 1 deletion manifests/base/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ spec:
containers:
- args:
- -alsologtostderr
image: mpioperator/mpi-operator:latest
image: ghcr.io/kubeflow/mpi-operator/controller:latest
name: mpi-operator
serviceAccountName: mpi-operator
4 changes: 2 additions & 2 deletions manifests/base/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ commonLabels:
app.kubernetes.io/name: mpi-operator
app.kubernetes.io/component: mpijob
images:
- name: mpioperator/mpi-operator
newName: mpioperator/mpi-operator
- name: ghcr.io/kubeflow/mpi-operator/controller
newName: ghcr.io/kubeflow/mpi-operator/controller
newTag: latest
4 changes: 2 additions & 2 deletions manifests/overlays/standalone/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ commonLabels:
app.kubernetes.io/name: mpi-operator
app.kubernetes.io/component: mpijob
images:
- name: mpioperator/mpi-operator
newName: mpioperator/mpi-operator
- name: ghcr.io/kubeflow/mpi-operator/controller
newName: ghcr.io/kubeflow/mpi-operator/controller
newTag: master
patches:
- target:
Expand Down
Loading