Skip to content

Conversation

liavweiss
Copy link

@liavweiss liavweiss commented Oct 5, 2025

Summary
This PR migrates the GitHub Actions workflow responsible for building and publishing all notebook server example images from the kubeflow/kubeflow repository to the kubeflow/notebooks repository.

Related: #614

Verification
Successfully built and published all notebook server example images:
https://github.com/liavweiss?tab=packages&repo_name=notebooks
image

I kept ghcr.io/kubeflow/kubeflow/notebook-servers as it is, after this comment #585 (comment)

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/ci area - related to ci label Oct 5, 2025
…b Action to kubeflow/notebooks - notebooks-v1 branch

Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
@andyatmiami
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this PR opened up and performing validations on your end @liavweiss . Workflow files included are properly customized for kubeflow/notebooks while also preserving the original logic present in kubeflow/kubeflow.

I can happily confirm I am able to replicate this success on my own fork:

Please note I did add a commit to my fork to ensure I was not publishing packages to kubeflow org

With that change - all images were rebuilt on a VERSION change and appear listed under my Packages in GitHub:

@google-oss-prow google-oss-prow bot added the lgtm label Oct 6, 2025
@thesuperzapper thesuperzapper changed the title feat: Migrate kubeflow/kubeflow example_notebook_servers_publish.yaml GitHub Action to kubeflow/notebooks - notebooks-v1 branch ci: add example notebooks server images publish workflows Oct 9, 2025
@thesuperzapper
Copy link
Member

Let's wait for other publish/release workflows to be ready before merging this to avoid potentially releasing new version tags on the notebook servers before we are ready.

I have created the build cache image ghcr.io/kubeflow/notebooks/notebook-servers/build-cache so we can safely merge this once we are ready.

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants