-
Notifications
You must be signed in to change notification settings - Fork 65
ci: add example notebooks server images publish workflows #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v1
Are you sure you want to change the base?
ci: add example notebooks server images publish workflows #640
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…b Action to kubeflow/notebooks - notebooks-v1 branch Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
3178942
to
823e1db
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this PR opened up and performing validations on your end @liavweiss . Workflow files included are properly customized for kubeflow/notebooks
while also preserving the original logic present in kubeflow/kubeflow
.
I can happily confirm I am able to replicate this success on my own fork:
Please note I did add a commit to my fork to ensure I was not publishing packages to kubeflow
org
With that change - all images were rebuilt on a VERSION
change and appear listed under my Packages
in GitHub:
Let's wait for other publish/release workflows to be ready before merging this to avoid potentially releasing new version tags on the notebook servers before we are ready. I have created the build cache image /hold |
Summary
This PR migrates the GitHub Actions workflow responsible for building and publishing all notebook server example images from the kubeflow/kubeflow repository to the kubeflow/notebooks repository.
Related: #614
Verification

Successfully built and published all notebook server example images:
https://github.com/liavweiss?tab=packages&repo_name=notebooks
I kept
ghcr.io/kubeflow/kubeflow/notebook-servers
as it is, after this comment #585 (comment)