Skip to content

ci: Upgrade Python to 3.12 and NodeJS to 24 for all imaged under example-notebook-servers #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: notebooks-v1
Choose a base branch
from
+14 −16
Open

ci: Upgrade Python to 3.12 and NodeJS to 24 for all imaged under example-notebook-servers #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/example-notebook-servers/codeserver-python/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ ARG CODESERVER_JUPYTER_VERSION=2024.11.0
ARG IPYKERNEL_VERSION=6.29.5
ARG MINIFORGE_VERSION=24.11.3-0
ARG PIP_VERSION=24.3.1
ARG PYTHON_VERSION=3.11.11
ARG PYTHON_VERSION=3.12.6

# setup environment for conda
ENV CONDA_DIR /opt/conda
Expand Down
22 changes: 10 additions & 12 deletions components/example-notebook-servers/jupyter-tensorflow-cuda/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ ARG TARGETARCH
# when updating past that version, either remove all TensorRT related packages,
# or investigate if there is a way to keep TensorRT support
ARG TENSORFLOW_VERSION=2.17.1
ARG TENSORRT_VERSION=8.6.1.post1
ARG TENSORRT_LIBS_VERSION=8.6.1
ARG TENSORRT_BINDINGS_VERSION=8.6.1
ARG TENSORRT_VERSION=10.2.0
ARG TENSORRT_LIBS_VERSION=10.2.0
ARG TENSORRT_BINDINGS_VERSION=10.2.0

# nvidia container toolkit
# https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/docker-specialized.html
Expand All @@ -26,26 +26,24 @@ ENV NVIDIA_REQUIRE_CUDA "cuda>=12.3"

# install - tensorflow
# - About '[and-cuda]' option: https://github.com/tensorflow/tensorflow/blob/v2.17.1/tensorflow/tools/pip_package/setup.py#L153-L164
# - TODO: when updating TensorRT, you might need to change `tensorrt`, `tensorrt-libs`, and `tensorrt-bindings`
# to `tensorrt-cu12`, `tensorrt-cu12-libs`, and `tensorrt-cu12-bindings` respectively
RUN python3 -m pip install --quiet --no-cache-dir --extra-index-url https://pypi.nvidia.com \
tensorflow[and-cuda]==${TENSORFLOW_VERSION} \
tensorrt==${TENSORRT_VERSION} \
tensorrt-libs==${TENSORRT_LIBS_VERSION} \
tensorrt-bindings==${TENSORRT_BINDINGS_VERSION}
tensorrt-cu12==${TENSORRT_VERSION} \
tensorrt-cu12-libs==${TENSORRT_LIBS_VERSION} \
tensorrt-cu12-bindings==${TENSORRT_BINDINGS_VERSION}

# create symlinks for TensorRT libs
# - https://github.com/tensorflow/tensorflow/issues/61986#issuecomment-1880489731
# - We are creating symlinks for the following libs, as this is where TF looks for them:
# - libnvinfer.so.8.6.1 -> libnvinfer.so.8
# - libnvinfer_plugin.so.8.6.1 -> libnvinfer_plugin.so.8
ENV PYTHON_SITE_PACKAGES /opt/conda/lib/python3.11/site-packages
# - libnvinfer.so.10.2.0 -> libnvinfer.so.10
# - libnvinfer_plugin.so.10.2.0 -> libnvinfer_plugin.so.10
ENV PYTHON_SITE_PACKAGES /opt/conda/lib/python3.12/site-packages
ENV TENSORRT_LIBS ${PYTHON_SITE_PACKAGES}/tensorrt_libs
RUN ln -s ${TENSORRT_LIBS}/libnvinfer.so.${TENSORRT_LIBS_VERSION%%.*} ${TENSORRT_LIBS}/libnvinfer.so.${TENSORRT_LIBS_VERSION} \
&& ln -s ${TENSORRT_LIBS}/libnvinfer_plugin.so.${TENSORRT_LIBS_VERSION%%.*} ${TENSORRT_LIBS}/libnvinfer_plugin.so.${TENSORRT_LIBS_VERSION}

# envs - cudnn, tensorrt
ENV LD_LIBRARY_PATH ${LD_LIBRARY_PATH}/nvidia/cudnn/lib:${TENSORRT_LIBS}
ENV LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+${LD_LIBRARY_PATH}:}${TENSORRT_LIBS}

# install - requirements.txt
COPY --chown=${NB_USER}:${NB_GID} requirements.txt /tmp
Expand Down
4 changes: 2 additions & 2 deletions components/example-notebook-servers/jupyter/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ USER root
ARG JUPYTERLAB_VERSION=4.3.5
ARG JUPYTER_VERSION=7.3.2
ARG MINIFORGE_VERSION=24.11.3-0
ARG NODE_MAJOR_VERSION=20
ARG NODE_MAJOR_VERSION=24
ARG PIP_VERSION=24.3.1
ARG PYTHON_VERSION=3.11.11
ARG PYTHON_VERSION=3.12.6

# install -- node.js
RUN export DEBIAN_FRONTEND=noninteractive \
Expand Down
2 changes: 1 addition & 1 deletion components/example-notebook-servers/rstudio/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ARG TARGETARCH
# args - software versions (python)
ARG MINIFORGE_VERSION=24.11.3-0
ARG PIP_VERSION=24.3.1
ARG PYTHON_VERSION=3.11.11
ARG PYTHON_VERSION=3.12.6

# args - software versions (R)
# - rstudio: https://dailies.rstudio.com/release/
Expand Down