Skip to content

[feature] Improve typing for @dsl.component to support strict LSPs #927

[feature] Improve typing for @dsl.component to support strict LSPs

[feature] Improve typing for @dsl.component to support strict LSPs #927

name: Validate Generated Files
on:
push:
branches:
- master
pull_request:
paths:
- '.github/workflows/validate-generated-files.yml'
- 'backend/api/**/*.proto'
- 'backend/api/**/go_http_client/**'
- 'backend/api/**/go_client/**'
- 'backend/api/**/python_http_client/**'
- 'backend/api/**/swagger/**'
- 'api/**/*.proto'
- 'api/**/*.go'
- 'kubernetes_platform/**/*.proto'
- 'kubernetes_platform/**/*.go'
- 'backend/src/crd/kubernetes/**/*.go'
- 'manifests/kustomize/base/crds/*.yaml'
- 'sdk/**/*.py'
- '!**/*.md'
- '!**/OWNERS'
jobs:
validate-generated-files:
runs-on: ubuntu-latest
strategy:
fail-fast: false
steps:
- uses: actions/checkout@v5
- name: Install Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.9
- name: Install protobuf dependencies & kfp-pipeline-spec
id: install-protobuf-deps
uses: ./.github/actions/protobuf
with:
generate_golang_proto: "true"
- name: Install kfp & kfp-kubernetes from source
id: install-kfp-k8s-deps
uses: ./.github/actions/kfp-k8s
with:
generate_golang_proto: "true"
- name: Generate K8s Native API CRDs
working-directory: ./backend/src/crd/kubernetes
run: make generate manifests
- name: Generate backend proto code v2beta1
working-directory: ./backend/api
env:
API_VERSION: v2beta1
run: make generate
- name: Generate backend proto code v1beta1
working-directory: ./backend/api
env:
API_VERSION: v1beta1
run: make generate
- name: Generate backend proto code v2beta1
working-directory: ./backend/api
env:
API_VERSION: v2beta1
run: make generate-kfp-server-api-package
- name: Generate backend proto code v1beta1
working-directory: ./backend/api
env:
API_VERSION: v1beta1
run: make generate-kfp-server-api-package
- name: Check for Changes
run: make check-diff
validate-backwards-compabitiblity:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- name: Install Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
- name: Validate Go proto code backwards compatibility
working-directory: ./backend/test/proto_tests
env:
UPDATE_EXPORTED: false
run: go test .