Skip to content

Conversation

sahil9001
Copy link

@sahil9001 sahil9001 commented Sep 21, 2025

Description of your changes:
Fixes #12155

Add an isV1 flag to ResourceSelector so its CustomTable can emit v1-compatible filters using op instead of the v2-only operation.

Update every v1-backed selector in the legacy New Run flow (pipeline picker, pipeline-version picker, and experiment picker) to pass isV1={true}.

Refresh the corresponding snapshots to reflect the new prop values.

Testing

npm test -- NewRun.test.tsx
npm test -- PipelinesDialog.test.tsx

Checklist:

Copy link

Hi @sahil9001. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] Pipeline version search fails on KFP v1 due to unsupported operation field in filter

1 participant