Skip to content

Conversation

112358fn
Copy link
Contributor

@112358fn 112358fn commented Sep 30, 2025

Description of your changes:

Closes #12308

Similarly to the solution implemented for the frontend in this PR: #11682
we should use the annotation workflows.argoproj.io/pod-name-format in the RetrievePodName function to get the right pod names when setting POD_NAMES=v1 in the workflows-controller

Checklist:

Copy link

Hi @112358fn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@juliusvonkohout
Copy link
Member

/ok-to-test

@droctothorpe droctothorpe force-pushed the fix/backend/retrieve-pod-name branch from 1a2f3e9 to c3e36a5 Compare October 1, 2025 18:15
@droctothorpe
Copy link
Collaborator

Nice catch and fix, @112358fn ! I rebased your branch.
/lgtm

@112358fn
Copy link
Contributor Author

112358fn commented Oct 3, 2025

@droctothorpe Thanks 🙏 !

@google-oss-prow google-oss-prow bot removed the lgtm label Oct 4, 2025
Copy link

New changes are detected. LGTM label has been removed.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from droctothorpe. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

@droctothorpe do you encounter the same as in #12308 (comment) ?

@juliusvonkohout
Copy link
Member

Signed-off-by: Alvaro Alonso <[email protected]>
@112358fn
Copy link
Contributor Author

112358fn commented Oct 6, 2025

@juliusvonkohout I have fixed the linting errors from my changes. I did not fix the rest of the errors as they will introduce changes to the PR that are not relevant to the issue we are addressing. I could open a separate PR to fix the linting errors outside my changes and then re-base this PR

@juliusvonkohout
Copy link
Member

@juliusvonkohout I have fixed the linting errors from my changes. I did not fix the rest of the errors as they will introduce changes to the PR that are not relevant to the issue we are addressing. I could open a separate PR to fix the linting errors outside my changes and then re-base this PR

As long as https://github.com/kubeflow/pipelines/actions/runs/18280622951/job/52042678894?pr=12303 is failing the merging will be blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[backend] Backwards compatibility error with POD_NAMES v1 for v1 runs

3 participants