-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(backend): RetrievePodName with POD_NAMES v1 #12303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @112358fn. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
/ok-to-test |
Signed-off-by: Alvaro Alonso <[email protected]>
1a2f3e9
to
c3e36a5
Compare
Nice catch and fix, @112358fn ! I rebased your branch. |
@droctothorpe Thanks 🙏 ! |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c02a783
to
c3e36a5
Compare
@droctothorpe do you encounter the same as in #12308 (comment) ? |
@112358fn please fix the linting errors https://github.com/kubeflow/pipelines/actions/runs/18257160080/job/51980095073?pr=12303 |
Signed-off-by: Alvaro Alonso <[email protected]>
@juliusvonkohout I have fixed the linting errors from my changes. I did not fix the rest of the errors as they will introduce changes to the PR that are not relevant to the issue we are addressing. I could open a separate PR to fix the linting errors outside my changes and then re-base this PR |
As long as https://github.com/kubeflow/pipelines/actions/runs/18280622951/job/52042678894?pr=12303 is failing the merging will be blocked. |
Description of your changes:
Closes #12308
Similarly to the solution implemented for the frontend in this PR: #11682
we should use the annotation
workflows.argoproj.io/pod-name-format
in theRetrievePodName
function to get the right pod names when settingPOD_NAMES=v1
in theworkflows-controller
Checklist: