Skip to content

Conversation

aniketpati1121
Copy link
Contributor

Updated Python version from 3.9 to 3.10 across:

  • SDK, DSL, and test data files
  • GitHub workflows
  • Backend and Dockerfiles

Copy link

Hi @aniketpati1121. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Oct 1, 2025

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@zazulam
Copy link
Collaborator

zazulam commented Oct 1, 2025

/ok-to-test

Copy link
Collaborator

@zazulam zazulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments on specifying the correct patch version in a few places.
Please update the sdk/python/setup.py and sdk/python/kfp/init.py as well to reflect the changes

Comment on lines +1 to +4

exp-456completed-run-123Production Pipeline Run *1Production pipeline execution for data processingB1


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file is needed, can you please remove

with tempfile.TemporaryDirectory() as tmpdir:

@dsl.component(base_image='docker.io/python:3.9.17')
@dsl.component(base_image='docker.io/python:3.10.17')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest python 3.10 version is 3.10.18, can you update the patch version to match.

def simple_pipeline(img: str):
task = empty_component()
# overwrite base_image="docker.io/python:3.9.17"
# overwrite base_image="docker.io/python:3.10.17"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update patch version to latest

with tempfile.TemporaryDirectory() as tmpdir:

@dsl.component(base_image='docker.io/python:3.9.17')
@dsl.component(base_image='docker.io/python:3.10.17')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update patch version to latest

def simple_pipeline():
task = empty_component()
# overwrite base_image="docker.io/python:3.9.17"
# overwrite base_image="docker.io/python:3.10.17"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update patch version to latest

base_image = _DEFAULT_BASE_IMAGE
warnings.warn(
("The default base_image used by the @dsl.component decorator will switch from 'python:3.9' to 'python:3.10' on Oct 1, 2025. To ensure your existing components work with versions of the KFP SDK released after that date, you should provide an explicit base_image argument and ensure your component works as intended on Python 3.10."
("The default base_image used by the @dsl.component decorator will switch from 'python:3.10' to 'python:3.10' on Oct 1, 2025. To ensure your existing components work with versions of the KFP SDK released after that date, you should provide an explicit base_image argument and ensure your component works as intended on Python 3.10."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the comment to reflect the change, reference.

The default base_image used by the @dsl.component decorator will switch from 'python:3.10' to 'python:3.11' on Oct 1, 2026. To ensure your existing components work with versions of the KFP SDK released after that date, you should provide an explicit base_image argument and ensure your component works as intended on Python 3.11.

Copy link
Collaborator

@zazulam zazulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I found I think that the python version specified in the workflow files used with the setup-python gh action need to be strings. I only think this is the case since the repo for that action has the usage specified as such and that the current error we are seeing in CI is related to parsing.

Run actions/setup-python@v4
with:
python-version: 3.1
check-latest: false
token: ***
update-environment: true
allow-prereleases: false
Installed versions
Version 3.1 was not found in the local cache
Error: The version '3.1' with architecture 'x64' was not found for Ubuntu 24.04.

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try setting the version within a string to prevent stripping.

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: '3.10'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringy version

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: '3.10'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringify version

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zazulam. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants