Skip to content

Conversation

@nsingla
Copy link
Contributor

@nsingla nsingla commented Nov 14, 2025

Changes Made

  1. Replaced the artifact download step (image-builds-with-cache.yml:71-77):
    - Removed actions/download-artifact@v4 which actually downloaded artifacts
    - Added nsingla/github-actions/github-artifacts@main with operation 'check' to only verify if artifacts exist
  2. Updated the Docker Buildx step condition (image-builds-with-cache.yml:82):
    - Changed from steps.artifact-download.outcome == 'failure'
    - To steps.artifact-check.outputs.artifact-exists == 'false'
    - Now it runs when the artifact does NOT exist (when we need to build)
  3. Removed the artifact cleanup step (previously lines 79-85):
    - Since we're no longer downloading artifacts, we don't need to clean them up
    - The action only checks for existence, doesn't actually download anything

Benefits of This Change

  • More efficient: No longer downloads artifacts unnecessarily just to check if they exist
  • Cleaner workflow: Removes the download-then-delete pattern
  • Better logic: Uses a proper boolean check (artifact-exists == 'false') instead of relying on step outcomes
  • Reduced network usage: Only queries artifact metadata instead of downloading full files

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/S and removed size/XL labels Nov 15, 2025
@nsingla nsingla force-pushed the gihub_artifact_check branch from d30e7d3 to 15cdf64 Compare November 15, 2025 17:53
Signed-off-by: Nelesh Singla <[email protected]>
@nsingla nsingla force-pushed the gihub_artifact_check branch from 15cdf64 to 12460f4 Compare November 16, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant