Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sparkctl #2368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ChenYi015
Copy link
Contributor

Purpose of this PR

Proposed changes:

Refactor sparkctl:

  • Use controller-runtime client instead of generated crd client to interact with API server
  • sparkctl status sub command is moved to sparkctl get so that it be consistent with kubectl get
  • Adjust the sparkctl directory structure as follows:
$ tree -L 2 cmd/sparkctl
cmd/sparkctl
├── README.md
├── create
│   ├── create.go
│   ├── create_test.go
│   ├── gcs.go
│   ├── s3.go
│   └── testdata
├── delete
│   └── delete.go
├── event
│   └── event.go
├── forward
│   └── forward.go
├── get
│   └── get.go
├── list
│   └── list.go
├── log
│   └── log.go
└── main.go

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chenyi015. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yi Chen <[email protected]>
@ChenYi015
Copy link
Contributor Author

/assign @jacobsalway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants