Skip to content

WIP: to #2708 feat add manager product extension point for controller startup #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: to #2708 feat add manager product extension point for controller startup #2728

wants to merge 3 commits into from
+862 −32

Conversation

@shadowinlife
Copy link
Contributor

@shadowinlife shadowinlife commented Nov 13, 2025 •
edited
Loading

Purpose of this PR

Please check out issue: #2708

Proposed changes:

  • introduce manager factory/product abstractions so custom ctrl.Manager implementations can be plugged in
  • expose --manager-product and fallback flags and surface them through Helm values/docs
  • document the extension point and add a sharded manager example module

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

I'm testing on this patch to confirm that it do not changed default list-watch behavior.

@google-oss-prow google-oss-prow bot requested a review from ImpSy November 13, 2025 04:09
@google-oss-prow
Copy link
Contributor

google-oss-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from nabuskey November 13, 2025 04:09
@shadowinlife shadowinlife changed the title to #2708 feat: add manager product extension point for controller startup WIP: to #2708 feat add manager product extension point for controller startup Nov 13, 2025
@shixing-gm
feat: add manager product extension point for controller startup
d29967e 
- introduce manager factory/product abstractions so custom ctrl.Manager implementations can be plugged in
- expose `--manager-product` and fallback flags and surface them through Helm values/docs
- document the extension point and add a sharded manager example module

Signed-off-by: 世行 <[email protected]>
@shadowinlife shadowinlife force-pushed the feat/infomer_sparkapplication_by_labels branch from 469ce35 to d29967e Compare November 13, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ImpSy ImpSy Awaiting requested review from ImpSy

@nabuskey nabuskey Awaiting requested review from nabuskey

Assignees

No one assigned

Labels

do-not-merge/work-in-progress size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shadowinlife @shixing-gm