Skip to content

chore: Replace the deprecated intstr.FromInt with intstr.FromInt32 #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 30, 2025

What this PR does / why we need it:

The FromInt has already been deprecated.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y tenzen-y changed the title chore: Replace the outdated intstr.FromInt with intstr.FromInt32 chore: Replace the deprecated intstr.FromInt with intstr.FromInt32 Jun 30, 2025
@tenzen-y tenzen-y force-pushed the fix-outdated-intstr-lib branch from bc70dd4 to 821cc86 Compare June 30, 2025 15:21
@coveralls
Copy link

coveralls commented Jun 30, 2025

Pull Request Test Coverage Report for Build 15976963797

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 29.282%

Totals Coverage Status
Change from base Build 15976448630: 0.0%
Covered Lines: 901
Relevant Lines: 3077

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tenzen-y!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4d47314 into kubeflow:master Jun 30, 2025
17 checks passed
@google-oss-prow google-oss-prow bot added this to the v2.0 milestone Jun 30, 2025
@tenzen-y tenzen-y deleted the fix-outdated-intstr-lib branch June 30, 2025 16:47
@andreyvelich
Copy link
Member

/cherry-pick release-2.0

@google-oss-robot
Copy link

@andreyvelich: new pull request created: #2697

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants