fix(runtimes): fix missing dependency in torchtune trainer image.#2887
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
|
@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: kubeflow/kubeflow-trainer-team. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Please can you add /assign @kubeflow/kubeflow-trainer-team |
Pull Request Test Coverage Report for Build 18427110343Details
💛 - Coveralls |
andreyvelich
left a comment
There was a problem hiding this comment.
Looks to be working now, thank you @Electronic-Waste!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…beflow#2887) Signed-off-by: Electronic-Waste <[email protected]>
…beflow#2887) Signed-off-by: Electronic-Waste <[email protected]>
What this PR does / why we need it:
This PR fix the missing dependency in torchtune trainer image by installing
build-essentials.After fixing this error, the torchtune trainer works as expected on my development cluster:
/cc @kubeflow/kubeflow-trainer-team
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2884
Checklist: