Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify code structure of training job api #1300

Merged
merged 6 commits into from
Jul 14, 2021
Merged

Unify code structure of training job api #1300

merged 6 commits into from
Jul 14, 2021

Commits on Jul 12, 2021

  1. Add docs, register in job apis 

    - Clean up register.go and use reference in groupversion_info.go (generated by kubebuilder) instead
- Add doc.go and register.go for framework missing them
- Remove global tag “+k8s:deepcopy-gen=package,register” and this should be taken care of by controller-gen.

Signed-off-by: Jiaxin Shan <[email protected]>
    @Jeffwan
    Jeffwan committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    3f95290 View commit details
    Browse the repository at this point in the history

  2. Generate defaults and openapi for all frameworks 

    1. Update codegen scripts to generate defaulters and openapi spec for all frameworks
2. Create defaults.go for framework which miss it.

Signed-off-by: Jiaxin Shan <[email protected]>
    @Jeffwan
    Jeffwan committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    7ddf016 View commit details
    Browse the repository at this point in the history

  3. Add Kind in constants.go 

    Signed-off-by: Jiaxin Shan <[email protected]>
    @Jeffwan
    Jeffwan committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    26f2f21 View commit details
    Browse the repository at this point in the history

  4. Update update-codegen to generate openapi-gen 

    Signed-off-by: Jiaxin Shan <[email protected]>
    @Jeffwan
    Jeffwan committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    15e4bb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Run goimports to format the files

    @Jeffwan
    Jeffwan committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    9fa6efe View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Add Plural and Singular to apis constants.go 

    Signed-off-by: Jiaxin Shan <[email protected]>
    @Jeffwan
    Jeffwan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    b1d6843 View commit details
    Browse the repository at this point in the history