KEP-2170: Add TrainJob conditions #2322
Open
+503
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tenzen-y
force-pushed
the
v2-add-reconcile-condition
branch
from
128a039
to
e1bd573
Compare
tenzen-y
force-pushed
the
v2-add-reconcile-condition
branch
2 times, most recently
from
8c638b4
to
fd61ff2
Compare
tenzen-y
force-pushed
the
v2-add-reconcile-condition
branch
from
fd61ff2
to
8ca03df
Compare
tenzen-y
commented
Nov 7, 2024
| @@ -51,7 +51,7 @@ type Framework struct { | |||
| } | |||
|
|
|||
| func (f *Framework) Init() *rest.Config { | |||
| log.SetLogger(zap.New(zap.WriteTo(ginkgo.GinkgoWriter), zap.UseDevMode(true))) | |||
| ctrl.SetLogger(zap.New(zap.WriteTo(ginkgo.GinkgoWriter), zap.Level(zapcore.Level(-5)), zap.UseDevMode(true))) | |||
There was a problem hiding this comment.
Surfacing the debug logs.
tenzen-y
force-pushed
the
v2-add-reconcile-condition
branch
from
8ca03df
to
665b605
Compare
Pull Request Test Coverage Report for Build 11732628418Details
💛 - Coveralls |
tenzen-y
force-pushed
the
v2-add-reconcile-condition
branch
2 times, most recently
from
4bb08b7
to
12514ab
Compare
tenzen-y
changed the title
|
/hold for review |
|
/assign @kubeflow/wg-training-leads |
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
v2-add-reconcile-condition
branch
from
12514ab
to
d5230f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I implemented the TrainJob condition mechanism based on https://github.com/kubeflow/training-operator/tree/master/docs/proposals/2170-kubeflow-training-v2#state-transition
However, the current implementation depends on the JobSet status.conditions opposed to the status.terminalState since the terminalState was introduced in JobSet v0.6, then the JobSet depends on the K8s lib 1.30 in #2299.
So, after we upgrade the K8s libs to 1.30, we can revisit the JobSet status.terminalState.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Part-of: #2207
Relates to #2170
Checklist: