website: added social media icon on readme and footer #3998

jaiakash · 2025-02-13T18:05:50Z

Fixes #3684
Fixes #3633
Fixes #3683

Hi, I have added

X (twitter), Slack, YouTube and KubeFlow CNCF icon in project readme
New twitter icon, YouTube and LinkedIn on footer

Screenshot 1:

Screenshot 2:

Signed-off-by: Akash Jaiswal <[email protected]>

google-oss-prow · 2025-02-13T18:06:01Z

Hi @jaiakash. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Akash Jaiswal <[email protected]>

Arhell

/ok-to-test

andreyvelich

/assign @hbelmiro @varodrig @juliusvonkohout @franciscojavierarceo @terrytangyuan

andreyvelich · 2025-02-19T08:39:24Z

README.md

+    <img src="https://img.shields.io/badge/CNCF%20Landscape-5699C6?logo=cncf&style=social" alt="KubeFlow CNCF Landscape" />
+  </a>
+
+  [![Slack](https://img.shields.io/badge/Slack-4A154B?style=for-the-badge&logo=slack&logoColor=white)](./docs/about/community/#kubeflow-slack-channels)


This link doesn't work, so maybe it is better to use to full link:
https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels

Added full url

the slack link is not working. Agree with @andreyvelich to use https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels

Added in latest commit

andreyvelich · 2025-02-19T08:39:52Z

README.md

+
+  [![Slack](https://img.shields.io/badge/Slack-4A154B?style=for-the-badge&logo=slack&logoColor=white)](./docs/about/community/#kubeflow-slack-channels)
+  [![LinkedIn](https://img.shields.io/badge/linkedin-%230077B5.svg?style=for-the-badge&logo=linkedin&logoColor=white)](https://www.linkedin.com/company/kubeflow)
+  [![YouTube](https://img.shields.io/badge/YouTube-%23FF0000.svg?style=for-the-badge&logo=YouTube&logoColor=white)](https://www.youtube.com/kubeflow)


Maybe this YouTube channel is more useful since we publish all meetings there
https://www.youtube.com/@KubeflowCommunity

agree with @andreyvelich suggestion to use https://www.youtube.com/@KubeflowCommunity

andreyvelich · 2025-02-19T08:40:32Z

README.md

+  [![LinkedIn](https://img.shields.io/badge/linkedin-%230077B5.svg?style=for-the-badge&logo=linkedin&logoColor=white)](https://www.linkedin.com/company/kubeflow)
+  [![YouTube](https://img.shields.io/badge/YouTube-%23FF0000.svg?style=for-the-badge&logo=YouTube&logoColor=white)](https://www.youtube.com/kubeflow)
+  [![X](https://img.shields.io/badge/X-%23000000.svg?style=for-the-badge&logo=X&logoColor=white)](https://x.com/kubeflow/)
+


Please also add this:
https://bsky.app/profile/kubefloworg.bsky.social

Added bluesky

Signed-off-by: Akash Jaiswal <[email protected]>

jaiakash · 2025-02-19T08:50:20Z

Here is the final version:

andreyvelich

Thanks @jaiakash
/lgtm
/assign @kubeflow/kubeflow-steering-committee @juliusvonkohout @franciscojavierarceo

franciscojavierarceo · 2025-02-19T12:01:13Z

/lgtm

thanks for this @jaiakash!!!

juliusvonkohout · 2025-02-20T10:20:02Z

I think https://github.com/kubeflow/website/pull/3998/files#r1961211039 is still open. maybe we should link both youtube channels otherwise i can approve and merge it. Please tell me if you have further objections.

jaiakash · 2025-02-20T10:24:28Z

I think #3998 (files) is still open. maybe we should link both youtube channels otherwise i can approve and merge it. Please tell me if you have further objections.

@juliusvonkohout are you suggesting to add 2 youtube links? Personally i feel one is appropriate.

Moreover, the https://www.youtube.com/@KubeflowCommunity links KubeFlow main youtube, twitter and website.

jaiakash

Final version.

juliusvonkohout · 2025-02-20T17:01:51Z

Then please let @andreyvelich approve, since he opened that discussion.

andreyvelich · 2025-02-20T17:09:16Z

It looks like formatting at the website is incorrect.
@jaiakash Can you take a look please ?

jaiakash · 2025-02-20T17:12:06Z

Hi @andreyvelich, I’m experiencing the same issue when using the Netlify link from the PR.

However, it works fine when I run it locally. Could you confirm if the screenshot you shared is from the Netlify test deployment for this PR?

And how can we verify the correct changes?

andreyvelich · 2025-02-20T17:15:25Z

You can check it in the Netlify preview:
https://deploy-preview-3998--competent-brattain-de2d6d.netlify.app/

jaiakash · 2025-02-20T17:20:46Z

Yeah i can see netlify preview, but there are differences in local preview and netflify preview. Is there some other configuration that I have to change.

Screen.Recording.2025-02-20.at.10.49.28.PM.mov

andreyvelich · 2025-02-20T17:52:22Z

@thesuperzapper Any thoughts ?

google-oss-prow · 2025-02-21T05:08:05Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2025-02-21T05:08:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jaiakash · 2025-02-21T05:28:46Z

Here is something similar i found, https://stackoverflow.com/questions/62616990/fontawesome-icons-not-appearing-when-deploying-website-to-netlify
But i don think that applies to us.

varodrig · 2025-02-21T19:28:27Z

ks fine when I run it locally. Could you confirm if the screenshot you shared is from the Netlify test deployment for this PR?

I'm experiencing the same using the same the source code locally and I'm not seeing https://x.com/kubeflow/

varodrig · 2025-02-21T21:09:31Z

thanks @jaiakash for working on this.
cc @thesuperzapper to review as well.

varodrig · 2025-02-25T03:23:52Z

/hold

waiting for updates

milinddethe15

@jaiakash You might need to update Font Awesome version to use the new logos (X, bluesky)

jaiakash · 2025-03-14T22:39:23Z

Hi @andreyvelich, @varodrig,

It looks like there is a version mismatch for font-awesome due to the docsy submodule we are using.
Currently, we are on docsy v0.6.0, which depends on:

font-awesome v6.2.0
hugo v0.124.1

Reference: Docsy v0.6.0 Dependencies.

To properly display the Bluesky icon, the new X (Twitter) icon, and YouTube, we need to:

Upgrade docsy from v0.6.0 to the latest compatible version.
Update the default Hugo version from 0.124.1 to 0.136.2+.
Update the documentation (README.md) to reflect these newer versions.

# TIP: to install hugo run the following commands
HOMEBREW_COMMIT="7b167101ab2dce314f563d372a808e4b16983d24" # 0.136.2 not 0.124.1

Test: layouts/partials and assets/scss code

jaiakash · 2025-03-14T22:45:16Z

For now, I think we have two action items to address this:

Add temporary static assets for X, Bluesky, and YouTube in the website footer so they display correctly.
Create a new issue to upgrade docsy to the latest version. This should include regression testing of all pages on the new version by the community. (I'm happy to help with this!)
Once docsy is upgraded, remove the temporary static icons and switch to font-awesome logos.

Also from discussions in #3954 and #3629, especially comment from #3954 (comment), I think 1 would be the way to solve this ( #3684 #3633 #3683) as of now.

Still, we can decide the priority order based on whether we want the icons/links in the footer immediately or if we should upgrade docsy first before displaying them properly.

Let me know your thoughts! 🚀

milinddethe15 · 2025-04-06T05:33:12Z

Hey @jaiakash, can you add static assets for those icons and use them?
We can’t upgrade Docsy, especially after what was done in #3981.

milinddethe15 · 2025-04-09T09:21:23Z

can you add static assets for those icons and use them?

Alt, easiest way can be: load font-awesome using CDN link

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.7.2/css/fontawesome.min.css">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.7.2/css/brands.min.css">

feat: added social media icons

636f10a

Signed-off-by: Akash Jaiswal <[email protected]>

google-oss-prow bot added the do-not-merge/work-in-progress label Feb 13, 2025

google-oss-prow bot requested review from andreyvelich, varodrig and zijianjoy February 13, 2025 18:05

google-oss-prow bot added the needs-ok-to-test label Feb 13, 2025

google-oss-prow bot added the size/L label Feb 13, 2025

feat: social media icons in footer

904e81a

Signed-off-by: Akash Jaiswal <[email protected]>

jaiakash mentioned this pull request Feb 13, 2025

Add LinkedIn Page Link to Kubeflow Website Footer #3683

Open

Arhell reviewed Feb 14, 2025

View reviewed changes

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Feb 14, 2025

jaiakash added 2 commits February 14, 2025 22:47

Merge branch 'kubeflow:master' into social-media-icon

0c90f4e

Merge branch 'kubeflow:master' into social-media-icon

51aac9c

andreyvelich reviewed Feb 19, 2025

View reviewed changes

google-oss-prow bot assigned franciscojavierarceo, hbelmiro, juliusvonkohout, terrytangyuan and varodrig Feb 19, 2025

feat: add bluesky, added community yt channel and fixed slack

2eeaa80

Signed-off-by: Akash Jaiswal <[email protected]>

andreyvelich reviewed Feb 19, 2025

View reviewed changes

google-oss-prow bot assigned andreyvelich Feb 19, 2025

google-oss-prow bot added the lgtm label Feb 19, 2025

jaiakash commented Feb 20, 2025

View reviewed changes

google-oss-prow bot removed the lgtm label Feb 21, 2025

google-oss-prow bot added the do-not-merge/hold label Feb 25, 2025

jaiakash changed the title ~~[wip]feat: added social media icon on readme and footer~~ feat: added social media icon on readme and footer Feb 25, 2025

google-oss-prow bot removed the do-not-merge/work-in-progress label Feb 25, 2025

jaiakash force-pushed the social-media-icon branch 2 times, most recently from 8b5cfad to a6601a6 Compare February 25, 2025 16:49

milinddethe15 reviewed Mar 12, 2025

View reviewed changes

jaiakash changed the title ~~feat: added social media icon on readme and footer~~ website: added social media icon on readme and footer Mar 14, 2025

jaiakash force-pushed the social-media-icon branch from 4535bc0 to 2eeaa80 Compare April 7, 2025 13:00

Merge branch 'master' into social-media-icon

069ece0

website: added social media icon on readme and footer #3998

Are you sure you want to change the base?

website: added social media icon on readme and footer #3998

Conversation

jaiakash commented Feb 13, 2025 • edited Loading

Screenshot 1:

Screenshot 2:

google-oss-prow bot commented Feb 13, 2025

Arhell left a comment

Choose a reason for hiding this comment

andreyvelich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaiakash Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaiakash commented Feb 19, 2025 • edited Loading

andreyvelich left a comment

Choose a reason for hiding this comment

franciscojavierarceo commented Feb 19, 2025

juliusvonkohout commented Feb 20, 2025

jaiakash commented Feb 20, 2025 • edited Loading

jaiakash left a comment • edited Loading

Choose a reason for hiding this comment

juliusvonkohout commented Feb 20, 2025

andreyvelich commented Feb 20, 2025

jaiakash commented Feb 20, 2025 • edited Loading

andreyvelich commented Feb 20, 2025

jaiakash commented Feb 20, 2025 • edited Loading

andreyvelich commented Feb 20, 2025

google-oss-prow bot commented Feb 21, 2025

google-oss-prow bot commented Feb 21, 2025

jaiakash commented Feb 21, 2025 • edited Loading

varodrig commented Feb 21, 2025

varodrig commented Feb 21, 2025

varodrig commented Feb 25, 2025

milinddethe15 left a comment

Choose a reason for hiding this comment

jaiakash commented Mar 14, 2025 • edited Loading

jaiakash commented Mar 14, 2025 • edited Loading

milinddethe15 commented Apr 6, 2025

milinddethe15 commented Apr 9, 2025

jaiakash commented Feb 13, 2025 •

edited

Loading

jaiakash Feb 21, 2025 •

edited

Loading

jaiakash commented Feb 19, 2025 •

edited

Loading

jaiakash commented Feb 20, 2025 •

edited

Loading

jaiakash left a comment •

edited

Loading

jaiakash commented Feb 20, 2025 •

edited

Loading

jaiakash commented Feb 20, 2025 •

edited

Loading

jaiakash commented Feb 21, 2025 •

edited

Loading

jaiakash commented Mar 14, 2025 •

edited

Loading

jaiakash commented Mar 14, 2025 •

edited

Loading