Fix batch/v1beta1 deprecated #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the community-components submodule to deploy `s3-syncer` on cluster v1.28. I found batch/v1beta is deprecated. So I went with batch/v1. We can use Helm's `Capabilities.APIVersions.Has` feature to support both apiVersions to deploy them on any kubernetes version Signed-off-by: Mohamed Rafraf <[email protected]>
kubermatic-bot
added
dco-signoff: yes
|
/lgtm |
|
LGTM label has been added. Git tree hash: de01ee8b1b74a9b67f94e50e0af40455ee0eb096
|
moelsayed
approved these changes
Apr 8, 2024
moelsayed
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
s3-syncerdeployment to support bothbatch/v1beta1andbatch/v1API versions for CronJobs, ensuring compatibility with Kubernetes clusters v1.21 and above.What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
I used the community-components submodule to deploy
s3-synceron cluster v1.28. I found batch/v1beta is deprecated. So I went with batch/v1.We can use Helm's
Capabilities.APIVersions.Hasfeature to support both apiVersions to deploy them on any kubernetes versionDoes this PR introduce a user-facing change?: