Skip to content

Use PAT_TOKEN instead of GH_TOKEN to automate PR #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

yue9944882
Copy link
Member

@yue9944882 yue9944882 commented Jun 5, 2025

Currently it's a pain to manually release new versions. The following is an example of what we manually did for releasing 24.0.0: > #4054 (comment)

1.33 Model regeneration PR: https://github.com/kubernetes-client/java/pull/4056

Cut release branch release-24

1.33 Model regeneration PR for legacy branch: https://github.com/kubernetes-client/java/pull/4059

Cut release branch release-legacy-24

Run release workflow for release-24: https://github.com/yue9944882/java/actions/runs/15217107346

Run release workflow for release-legacy-24: https://github.com/yue9944882/java/actions/runs/15218963083

Release 24.0.0 PR: https://github.com/kubernetes-client/java/pull/4062

Release 24.0.0-legacy PR: https://github.com/kubernetes-client/java/pull/4063

Publish 24.0.0 tag

Publish 24.0.0-legacy tag

This is due to the default github action token losing the access for creating pull requests via the workflow. As a workaround, this PR allows the release job to use PAT_TOKEN which is my personal account's token that only contains PR creation permission so the release process can be automated again.

/cc @brendandburns

@k8s-ci-robot
Copy link
Contributor

@yue9944882: GitHub didn't allow me to request PR reviews from the following users: brendanburns.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Currently it's a pain to manually release new versions. The following is an example of what we manually did for releasing 24.0.0: > #4054 (comment)

1.33 Model regeneration PR: https://github.com/kubernetes-client/java/pull/4056

Cut release branch release-24

1.33 Model regeneration PR for legacy branch: https://github.com/kubernetes-client/java/pull/4059

Cut release branch release-legacy-24

Run release workflow for release-24: https://github.com/yue9944882/java/actions/runs/15217107346

Run release workflow for release-legacy-24: https://github.com/yue9944882/java/actions/runs/15218963083

Release 24.0.0 PR: https://github.com/kubernetes-client/java/pull/4062

Release 24.0.0-legacy PR: https://github.com/kubernetes-client/java/pull/4063

Publish 24.0.0 tag

Publish 24.0.0-legacy tag

This is due to the default github action token losing the access for creating pull requests via the workflow. As a workaround, this PR allows the release job to use PAT_TOKEN which is my personal account's token that only contains PR creation permission so the release process can be automated again.

/cc @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2025
@brendandburns
Copy link
Contributor

I don't love using personal access tokens for this, but it's an ok work around for now. Let's make sure we continue to keep the scope limited to PR creation.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5213048 into kubernetes-client:master Jun 5, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants