feat: Use WMI to implement Disk API to reduce PowerShell overhead#376
Conversation
|
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
7efda28 to
93a2582
Compare
93a2582 to
d170ae9
Compare
d170ae9 to
2b4087a
Compare
|
Rebased after #360 is merged. |
|
/test pull-kubernetes-csi-csi-proxy-integration |
|
@andyzhangx Could you verify these APIs with Azure Disk CSI driver? |
andyzhangx
left a comment
There was a problem hiding this comment.
/hold
sure, I will verify this later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, laozc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR leverages of WMI interfaces to replace the PowerShell functions for Disk APIs,
It improves the overall performance of csi-proxy.
Partially for #193
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: