-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove volumeGroupSnapshotRef immutable validation rule #1184
Remove volumeGroupSnapshotRef immutable validation rule #1184
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
I tested the volume group snapshot static and dynamic provisioning, and everything is fine. |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
We need to remove the validation rule that ensures volumeGroupSnapshotRef is immutable.
This is because that UID needs to be set by the snapshot controller after volumeGroupSnapshotRef is populated with name and namespace for pre-provisioned VolumeGroupSnapshotContent.
This immutable validation rule was added as part of this PR #1073 to use CEL to replace the validation added in the validation webhook:
However, in the original validation webhook, we never had this rule:
https://github.com/kubernetes-csi/external-snapshotter/blob/v7.0.2/pkg/validation-webhook/validation.go#L52
With this rule, the snapshot controller won't be able to set UID for volumeGroupSnapshotRef after it was populated with name and namespace initially. So we need to remove this rule.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: