Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable VolumeGroupSnapshot feature flag #901

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Disable VolumeGroupSnapshot feature flag #901

merged 1 commit into from
Sep 11, 2023

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Sep 8, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Disable the flag for now. Will enable it when the feature is fully implemented.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Disable the enable-volume-group-snapshots feature flag.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 8, 2023
@xing-yang xing-yang changed the title Disable VolumeGroupSnapshot feature flag WIP: Disable VolumeGroupSnapshot feature flag Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2023
@xing-yang
Disable VolumeGroupSnapshot feature flag
bb29899 
Disable the flag for now. Will enable it when
the feature is fully implemented.
@xing-yang xing-yang changed the title WIP: Disable VolumeGroupSnapshot feature flag Disable VolumeGroupSnapshot feature flag Sep 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2023
@msau42
Copy link
Collaborator

msau42 commented Sep 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit b1c4821 into kubernetes-csi:master Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@pohly pohly Awaiting requested review from pohly

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xing-yang @k8s-ci-robot @msau42