Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for v6.3.0 #908

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

xing-yang
Copy link
Collaborator

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2023
### Feature

- Add a marker to the snapshot-controller manifests to enable feature gates in CSI prow jobs. ([#790](https://github.com/kubernetes-csi/external-snapshotter/pull/790), [@RaunakShah](https://github.com/RaunakShah))
- Create Volume functionality for volume group snapshots ([#826](https://github.com/kubernetes-csi/external-snapshotter/pull/826), [@RaunakShah](https://github.com/RaunakShah))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update README as well this? Is there a k8s version requirement?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is not complete yet. CreateVolumeGroup is implemented but DeleteVolumeGroup is not (there is a WIP PR but it is not complete). I temporarily disabled the feature to prevent people from using it. I have the following item in the changelog that disabled the feature. Let me know if I should call this out more clearly.

- Disable the enable-volume-group-snapshots feature flag. ([#901](https://github.com/kubernetes-csi/external-snapshotter/pull/901), [@xing-yang](https://github.com/xing-yang))

Copy link
Collaborator Author

@xing-yang xing-yang Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to this. Let me know what you think.

Create Volume functionality for volume group snapshots (Note: this feature is partially implemented and therefore it is not ready for use) 

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove any notes about volumegroup snapshot until the feature is usable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. That's probably better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the removed ones in a different commit: de93167

Remove them to avoid confusion.
Will add back when the feature is complete.
@msau42
Copy link
Collaborator

msau42 commented Sep 13, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a6ac2ee into kubernetes-csi:master Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants