-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for v6.3.0 #908
Add changelog for v6.3.0 #908
Conversation
CHANGELOG/CHANGELOG-6.3.md
Outdated
### Feature | ||
|
||
- Add a marker to the snapshot-controller manifests to enable feature gates in CSI prow jobs. ([#790](https://github.com/kubernetes-csi/external-snapshotter/pull/790), [@RaunakShah](https://github.com/RaunakShah)) | ||
- Create Volume functionality for volume group snapshots ([#826](https://github.com/kubernetes-csi/external-snapshotter/pull/826), [@RaunakShah](https://github.com/RaunakShah)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update README as well this? Is there a k8s version requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature is not complete yet. CreateVolumeGroup is implemented but DeleteVolumeGroup is not (there is a WIP PR but it is not complete). I temporarily disabled the feature to prevent people from using it. I have the following item in the changelog that disabled the feature. Let me know if I should call this out more clearly.
- Disable the enable-volume-group-snapshots feature flag. ([#901](https://github.com/kubernetes-csi/external-snapshotter/pull/901), [@xing-yang](https://github.com/xing-yang))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to this. Let me know what you think.
Create Volume functionality for volume group snapshots (Note: this feature is partially implemented and therefore it is not ready for use)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove any notes about volumegroup snapshot until the feature is usable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. That's probably better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the removed ones in a different commit: de93167
520055b
to
350388a
Compare
Remove them to avoid confusion. Will add back when the feature is complete.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: