Checking for taint karpenter.sh/disrupted:NoSchedule while checking if node is suitable to handle traffic.
#4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
kahirokunn
force-pushed
the
adding-issue-taint
branch
from
10cdaa0 to
a10d656
Compare
kahirokunn
changed the title
karpenter.sh/disrupted:NoSchedule while checking if node is suitable to handle traffic.
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/test all |
|
I would appreciate if someone could give me a review. Thx 🙏 |
|
/ok-to-test |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thank you! I want to merge! |
wweiwei-li
reviewed
Jan 23, 2025
kahirokunn
force-pushed
the
adding-issue-taint
branch
from
a10d656 to
3437f54
Compare
k8s-ci-robot
removed
the
lgtm
kahirokunn
force-pushed
the
adding-issue-taint
branch
from
3437f54 to
f5dca77
Compare
…e checking if node is suitable to handle traffic. Signed-off-by: kahirokunn <[email protected]>
kahirokunn
force-pushed
the
adding-issue-taint
branch
from
f5dca77 to
6b50067
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kahirokunn, shraddhabang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4023
Description
Checking if the current node is tainted with Karpenter and avoid marking that node as healthy so that it could be removed from load balancer target groups.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯