Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat GW API] Add initial reconciler + grant enforcement #4125

Merged
merged 3 commits into from
Apr 9, 2025
Merged

[feat GW API] Add initial reconciler + grant enforcement #4125

merged 3 commits into from
Apr 9, 2025

Conversation

zac-nixon
Copy link
Collaborator

Issue

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 3, 2025
shraddhabang
shraddhabang reviewed Apr 4, 2025
View reviewed changes
pkg/config/feature_gates.go Outdated
LBCapacityReservation Feature = "LBCapacityReservation"
SubnetDiscoveryByReachability Feature = "SubnetDiscoveryByReachability"
GatewayAPI Feature = "ELBGatewayAPI"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we have separate flags for ALB and NLB gateway controllers? This way we can separate out the standard and experimental versions for conformance tests if needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

config/rbac/role.yaml
- apiGroups:
- gateway.networking.k8s.io
resources:
- udproutes/status
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO for me: Add L7 routes

controllers/gateway/constants.go Outdated
albGatewayController = "gateway.k8s.aws/alb"

// albGatewayTagPrefix the tag applied to all resources created by the ALB Gateway controller.
albGatewayTagPrefix = "gateway.k8s.aws.nlb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: gateway.k8s.aws.alb

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. will fix

shraddhabang
shraddhabang reviewed Apr 4, 2025
View reviewed changes
controllers/gateway/constants.go Outdated

const (
// nlbGatewayController gateway controller name for NLB
nlbGatewayController = "gateway.k8s.aws/nlb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making these constants with a CapitalCase name (e.g., NlbGatewayController) so that it can be accessed by event handlers and other packages.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

shraddhabang
shraddhabang reviewed Apr 8, 2025
View reviewed changes
pkg/config/feature_gates.go Outdated
@@ -24,7 +24,8 @@ const (
ALBSingleSubnet Feature = "ALBSingleSubnet"
LBCapacityReservation Feature = "LBCapacityReservation"
SubnetDiscoveryByReachability Feature = "SubnetDiscoveryByReachability"
GatewayAPI Feature = "ELBGatewayAPI"
NLBGatewayAPI Feature = "NLBELBGatewayAPI"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we just simply name them NLBGatewayAPI and ALBGatewayAPI?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

shraddhabang
shraddhabang reviewed Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@shraddhabang shraddhabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@shraddhabang
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit b0582a8 into kubernetes-sigs:main Apr 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shraddhabang shraddhabang shraddhabang left review comments

@oliviassss oliviassss Awaiting requested review from oliviassss

Assignees

@shraddhabang shraddhabang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zac-nixon @k8s-ci-robot @shraddhabang