[feat GW API] Add initial reconciler + grant enforcement#4125
[feat GW API] Add initial reconciler + grant enforcement#4125k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
pkg/config/feature_gates.go
Outdated
| SubnetDiscoveryByReachability Feature = "SubnetDiscoveryByReachability" | ||
| LBCapacityReservation Feature = "LBCapacityReservation" | ||
| SubnetDiscoveryByReachability Feature = "SubnetDiscoveryByReachability" | ||
| GatewayAPI Feature = "ELBGatewayAPI" |
There was a problem hiding this comment.
Shall we have separate flags for ALB and NLB gateway controllers? This way we can separate out the standard and experimental versions for conformance tests if needed.
| - apiGroups: | ||
| - gateway.networking.k8s.io | ||
| resources: | ||
| - udproutes/status |
There was a problem hiding this comment.
TODO for me: Add L7 routes
controllers/gateway/constants.go
Outdated
| albGatewayController = "gateway.k8s.aws/alb" | ||
|
|
||
| // albGatewayTagPrefix the tag applied to all resources created by the ALB Gateway controller. | ||
| albGatewayTagPrefix = "gateway.k8s.aws.nlb" |
There was a problem hiding this comment.
NIT: gateway.k8s.aws.alb
controllers/gateway/constants.go
Outdated
|
|
||
| const ( | ||
| // nlbGatewayController gateway controller name for NLB | ||
| nlbGatewayController = "gateway.k8s.aws/nlb" |
There was a problem hiding this comment.
Consider making these constants with a CapitalCase name (e.g., NlbGatewayController) so that it can be accessed by event handlers and other packages.
pkg/config/feature_gates.go
Outdated
| LBCapacityReservation Feature = "LBCapacityReservation" | ||
| SubnetDiscoveryByReachability Feature = "SubnetDiscoveryByReachability" | ||
| GatewayAPI Feature = "ELBGatewayAPI" | ||
| NLBGatewayAPI Feature = "NLBELBGatewayAPI" |
There was a problem hiding this comment.
nit: Can we just simply name them NLBGatewayAPI and ALBGatewayAPI?
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
3 participants
Issue
Description
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯