-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authenticationConfiguration to Ingress Class Params #4129
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kellyyan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kellyyan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
ipv4IPAMPoolId: | ||
description: IPv4IPAMPoolId defines the IPAM pool ID used for | ||
IPv4 Addresses on the ALB. | ||
- additionalPrinterColumns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the CRDs for helm as well by running make crds
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in revision
e4b5256
to
ebbceec
Compare
|
||
if ingressClassParamsAvailable { | ||
// Indexes using IngressClassParams should only be set up if IngressClassParams Customer Resource Definition (CRD) is installed | ||
if err := fieldIndexer.IndexField(ctx, &networking.Ingress{}, ingress.IndexKeySecretRefName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of repeating the same index field statement twice can you do something like this:
var ingClassParams *elbv2api.IngressClassParams
if ingressClassParamsAvailable {
ingClassParams = &elbv2api.IngressClassParams{}
}
Then you can set up the indexers ->
if err := fieldIndexer.IndexField(ctx, &networking.Ingress{}, ingress.IndexKeySecretRefName,
func(obj client.Object) []string {
return r.referenceIndexer.BuildSecretRefIndexes(context.Background(), ingClassParams, obj.(*networking.Ingress))
},
); err != nil {
return err
}
if err := fieldIndexer.IndexField(ctx, &corev1.Service{}, ingress.IndexKeySecretRefName,
func(obj client.Object) []string {
return r.referenceIndexer.BuildSecretRefIndexes(context.Background(), ingClassParams, obj.(*corev1.Service))
},
); err != nil {
return err
}
ebbceec
to
41843f3
Compare
41843f3
to
8d85071
Compare
/retest |
@kellyyan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issue
#3858
Description
authenticationConfiguration
to IngressClassParams, allowing users to configure the authentication for all Ingresses in the IngressGroup associated with the IngressClassingress_class.md
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯