✨ Helm: Expose deployment spec for all provider types#984
✨ Helm: Expose deployment spec for all provider types#984andreipantelimonuip wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
|
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @andreipantelimonuip! |
|
Hi @andreipantelimonuip. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Andrei Pantelimon <[email protected]>
f0d3e13 to
483a526
Compare
|
/ok-to-test |
furkatgofurov7
left a comment
There was a problem hiding this comment.
@andreipantelimonuip hey,
Can we add some tests for this change?
What this PR does / why we need it:
This change exposes the deployment spec configuration in the Helm chart for all provider types (Core, Bootstrap, ControlPlane, Infrastructure, Addon, IPAM).
The provider CRDs already support these fields - this exposes them through the chart values.
Supported fields: replicas, nodeSelector, tolerations, affinity, containers, serviceAccountName, imagePullSecrets
Which issue(s) this PR fixes :
Fixes #916
Fixes #955