Skip to content

🚀 Add 1.35.0-alpha.3 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

🚀 Add 1.35.0-alpha.3 #1303

merged 1 commit into from
Nov 7, 2025
+2 −0

Conversation

@bear-redhat
Copy link
Contributor

@bear-redhat bear-redhat commented Nov 7, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

Hi @bear-redhat. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2025
@bear-redhat bear-redhat changed the title Test #1297 Add 1.35.0-alpha.3 Nov 7, 2025
@bear-redhat bear-redhat marked this pull request as ready for review November 7, 2025 00:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@bear-redhat bear-redhat mentioned this pull request Nov 7, 2025
Merged
@bear-redhat bear-redhat changed the title Add 1.35.0-alpha.3 🚀 Add 1.35.0-alpha.3 Nov 7, 2025
@bear-redhat
Copy link
Contributor Author

bear-redhat commented Nov 7, 2025

/assign @sbueringer

sbueringer
sbueringer reviewed Nov 7, 2025
View reviewed changes
hack/envtest/_matrix/v1.35.0-alpha.3.yaml Outdated
@@ -0,0 +1,2 @@
go: 1.24
Copy link
Member

@sbueringer sbueringer Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be go 1.25 (https://github.com/kubernetes/kubernetes/blob/v1.35.0-alpha.3/.go-version but without patch version please)

Copy link
Contributor Author

@bear-redhat bear-redhat Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. sorry i was not aware there are certain go version dependencies here.

Copy link
Member

@sbueringer sbueringer Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. We just try to use the same as Kubernetes itself

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

LGTM label has been added.

Git tree hash: c1c48eda79ba8bef3c828ce9f294db91c5043088

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bear-redhat, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit d37f65f into kubernetes-sigs:main Nov 7, 2025
9 checks passed
@bear-redhat
Copy link
Contributor Author

bear-redhat commented Nov 7, 2025

looks like the Action failure is not relevant to us.

@bear-redhat
Copy link
Contributor Author

bear-redhat commented Nov 7, 2025

Release built for windows aarch64

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025

looks like the Action failure is not relevant to us.

Yup exactly. Once upon a time we had this fully automated. Then permissions on the org changed and since then I have to create this PR manually: #1304

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025

Release built for windows aarch64

Would be great if you can test if the binaries work with envtest once #1304 merges.

Unfortunately setup-envtest does not support pre-releases. But you can either use the envtest library (https://github.com/kubernetes-sigs/controller-runtime/blob/b4232f09de39f35320837a8dee0d0e8c9cd73e74/pkg/envtest/server.go#L158-L169) or download and extract the binaries manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@vincepri vincepri Awaiting requested review from vincepri

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bear-redhat @k8s-ci-robot @sbueringer