-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s dependencies to v0.32.2 #194
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: naemono The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @naemono! |
Hi @naemono. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
I replicated the golangci-lint errors locally noted in ci failure:
which seems to be related to the version of golangci-lint, as upgrading to the version prior to go 1.24 support (1.63.4) fixes the issue, but brought up more linting issues.
Which I have additionally resolved in 5606f1f. |
/retest |
|
(feels like a rabbit-hole I'm going down here) I also had to update openapi generated file(s) in 13670a5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @naemono for doing this.
/lgtm
It saves the effort to update the previous PR sent by the dependent robot.
@@ -7,7 +7,7 @@ GOPATH:=$(shell go env GOPATH) | |||
|
|||
VERSION?=latest | |||
|
|||
GOLANGCI_VERSION:=1.55.2 | |||
GOLANGCI_VERSION:=1.63.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Just out of curiosity, is it the mandatory thing to bump golangci-lint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was throwing all sorts of errors in previous ci runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, got it.
By the way, it would be great to quash the commits for clean history. |
I can do this. No worries. |
Upgrade golangci-lint. Fix additional linter issues. increase golangci-lint deadline/timeout change to timeout instead of deadline. update openapi generated file.
13670a5
to
87b5566
Compare
@RainbowMango These have been rebased. Feel free to retest, and merge if things are 🟢 Thanks! |
/triage accepted |
/lgtm Let's wait approval from @dgrisonnet . Just a reminder, please consider if you need to tag new releases before(v1.31.0) and after(v1.32.0) this PR. |
I didn't want to contribute/commit directly to #193, but the reason the PR is failing is because of https://github.com/kubernetes/kubernetes/pull/128196/files (
k8s.io/apiserver/pkg/util/version
was renamed tok8s.io/component-base/version
).This should both upgrade the deps, and resolve the failing import issue.
Feel free to either accept this PR, or simply update the previous PR. (cc @dgrisonnet)