Skip to content

chore(codequality): added linter grouper #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented May 26, 2025

What does it do ?

The size seems huge, not made any changes except grouped variables and constants

Motivation

Makes a code review simpler, as static checks resolved by the linter, so we could spend more time solving actual problems

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from mloiseleur and szuecs May 26, 2025 10:05
@ivankatliarchuk ivankatliarchuk force-pushed the chore-codequality-linter-grouper branch from 1706460 to aba3562 Compare May 26, 2025 10:12
@ivankatliarchuk ivankatliarchuk force-pushed the chore-codequality-linter-grouper branch from aba3562 to 968366e Compare May 26, 2025 10:12
@ivankatliarchuk ivankatliarchuk force-pushed the chore-codequality-linter-grouper branch from e23dfa5 to 4b55453 Compare May 26, 2025 18:30
@ivankatliarchuk
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 26, 2025
@mloiseleur
Copy link
Collaborator

It provides benefits on some files and, at the same time, on many other files it force to create a group even on single entry, like this:

image

Shouldn't we configure it to keep it more simple, without group, when there is only one entry ? 🤔

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as draft May 30, 2025 07:19
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2025
@ivankatliarchuk
Copy link
Contributor Author

ok will review/re-do this pr

@ivankatliarchuk
Copy link
Contributor Author

Need to think about it
/close

@k8s-ci-robot
Copy link
Contributor

@ivankatliarchuk: Closed this PR.

In response to this:

Need to think about it
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants