Skip to content

fix(source/service): disable pod and endpointSlices informers when they are not needed #5646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(source/service): disable pod and endpointSlices informers when they are not needed #5646

wants to merge 3 commits into from
+272 −68

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Jul 14, 2025 •
edited
Loading

What does it do ?

  • disables informers when only --service-type-filter=LoadBalancer is used or --service-type-filter=ExternalName
  • reduces memory and cpu footprint

Motivation

Fixes #4955

Previous PR #5613

Follow-up issue(s):

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mloiseleur July 14, 2025 11:52
@k8s-ci-robot k8s-ci-robot requested a review from szuecs July 14, 2025 11:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 14, 2025
@ivankatliarchuk ivankatliarchuk changed the title fix(source/service): conditinally pod and endpointSlicesInformer fix(source/service): conditinally disable pod and endpointSlices Informers Jul 14, 2025
@ivankatliarchuk
Copy link
Contributor Author

Hi @qin-nz

Can you confirm that this PR fixes your issue. If needed, see how to test a PR ?. This will require golang to be installed.

@mloiseleur mloiseleur changed the title fix(source/service): conditinally disable pod and endpointSlices Informers fix(source/service): disable pod and endpointSlices informers when they are not needed Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary access to v1.Pod lead to timeout.
2 participants
@ivankatliarchuk @k8s-ci-robot