Skip to content

feat(coredns): rename ownerId and ownedBy to owner #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
farodin91 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(coredns): rename ownerId and ownedBy to owner #6032

farodin91 wants to merge 1 commit into from
+120 −74

Conversation

@farodin91
Copy link
Contributor

@farodin91 farodin91 commented Dec 17, 2025

What does it do ?

  • Rename all usage of any owner variant to owner
  • Set the label to owner from the field (reduce confuse)

Motivation

We looked again into the code were a bit confused about naming as we had ownerID, ownedBy, and owner.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. provider Issues or PRs related to a provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 17, 2025

Hi @farodin91. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2025
@farodin91
Copy link
Contributor Author

farodin91 commented Dec 17, 2025

@ivankatliarchuk I thought to make this PR as fast as possible. My commit isn't released yet.

@mloiseleur
Copy link
Collaborator

mloiseleur commented Dec 19, 2025

/ok-to-test

@farodin91 It looks like a breaking change. Is it?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2025
@farodin91
Copy link
Contributor Author

farodin91 commented Dec 19, 2025

@mloiseleur Yes, but the original change was released yet. #5921

@coveralls
Copy link

coveralls commented Dec 19, 2025

Pull Request Test Coverage Report for Build 20372499713

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on rename-owner at 78.704%
Totals Coverage Status
Change from base Build 20368853975: 78.7%
Covered Lines: 16028
Relevant Lines: 20365
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 19, 2025

Pull Request Test Coverage Report for Build 20370815806

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on rename-owner at 78.704%
Totals Coverage Status
Change from base Build 20368853975: 78.7%
Covered Lines: 16028
Relevant Lines: 20365
💛 - Coveralls

ivankatliarchuk
ivankatliarchuk suggested changes Dec 23, 2025
View reviewed changes
provider/coredns/coredns.go
}
log.Debugf("Creating new ep (%s) with new service host (%s)", ep, service.Host)
}
if p.strictlyOwned {
Copy link
Member

@ivankatliarchuk ivankatliarchuk Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too clear why this if is required

provider/coredns/coredns.go
endpoint.RecordTypeTXT,
service.Text,
)
if p.strictlyOwned {
Copy link
Member

@ivankatliarchuk ivankatliarchuk Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, why if is required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szuecs szuecs Awaiting requested review from szuecs

@vflaux vflaux Awaiting requested review from vflaux

1 more reviewer

@ivankatliarchuk ivankatliarchuk ivankatliarchuk requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivankatliarchuk ivankatliarchuk

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs ok-to-test Indicates a non-member PR verified by an org member that is safe to test. provider Issues or PRs related to a provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@farodin91 @k8s-ci-robot @mloiseleur @coveralls @ivankatliarchuk