Skip to content

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Dec 30, 2025

What does it do ?

I've added only tests, to explicitly capture behaviour and make it obvious. At the memont, to my understanding AWS ALB controller for NLB creates two hostnames, one prefixed with internal-.

I've explained solution here #5661 (comment).

If we think there are other options, like flag, annotation or some sort of regex or filter I could implement in this or follow-up PR.

It's great to have a better support for AWS ALB, like automated management of records, same time the ALB controller behaviour is quite unpredictable and not well documented. Happy to follow advice

Motivation

Fixes #5661

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs December 30, 2025 00:39
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2025
@coveralls
Copy link

coveralls commented Dec 30, 2025

Pull Request Test Coverage Report for Build 20618885687

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 384 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.06%) to 78.861%

Files with Coverage Reduction New Missed Lines %
gateway_udproute.go 2 92.59%
gateway_grpcroute.go 2 92.59%
gateway_tlsroute.go 2 92.59%
gateway_httproute.go 2 92.59%
gateway_tcproute.go 2 92.59%
source.go 2 72.22%
openshift_route.go 3 85.0%
gateway_hostname.go 4 42.86%
contour_httpproxy.go 7 84.35%
skipper_routegroup.go 7 39.34%
Totals Coverage Status
Change from base Build 20569555245: -0.06%
Covered Lines: 15814
Relevant Lines: 20053

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2025
@mloiseleur mloiseleur changed the title chore(ingress): added tests to cover behaviour for AWS ALB and NLB test(ingress): cover behavior for AWS ALB and NLB Dec 30, 2025
@mloiseleur mloiseleur changed the title test(ingress): cover behavior for AWS ALB and NLB chore(aws): document and test behavior for ALB and NLB Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS ALB Controller Frontend NLB and external-dns

4 participants