-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(aws): document and test behavior for ALB and NLB #6063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(aws): document and test behavior for ALB and NLB #6063
Conversation
Signed-off-by: ivan katliarchuk <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 20618885687Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Co-authored-by: vflaux <[email protected]>
What does it do ?
I've added only tests, to explicitly capture behaviour and make it obvious. At the memont, to my understanding AWS ALB controller for NLB creates two hostnames, one prefixed with
internal-.I've explained solution here #5661 (comment).
If we think there are other options, like flag, annotation or some sort of regex or filter I could implement in this or follow-up PR.
It's great to have a better support for AWS ALB, like automated management of records, same time the ALB controller behaviour is quite unpredictable and not well documented. Happy to follow advice
Motivation
Fixes #5661
More