Skip to content

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Dec 31, 2025

What does it do ?

Don't be scared by it's size

Mainly it contains detailed explanation of a enchancement as well as code examples + how I'm going to implement it with detailed explanation

There is no need to review it all. When I'm going to open a PR - not sure most likely going to start working on it mid-end January. I'll reference this document, and will remove code fragments from here.

~ 4000 lines a code examples, and I'll remove them one buy one when the feature gets implemnted

So far high level improvements proposed

I'll try to provide links as well. Order is not guaranteed except 1. If you have time to read, welcome. What I mainly looking for now here, is where feature make sense or 100% no

Motivation

FQDN is just great feature, it reduces annotation, flags and other configs and super flexible.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: ivan katliarchuk <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 31, 2025
@coveralls
Copy link

coveralls commented Dec 31, 2025

Pull Request Test Coverage Report for Build 20624666634

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 78.861%

Totals Coverage Status
Change from base Build 20617539960: 0.005%
Covered Lines: 15814
Relevant Lines: 20053

💛 - Coveralls

@ivankatliarchuk ivankatliarchuk marked this pull request as draft December 31, 2025 18:00
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants