Skip to content

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Jan 1, 2026

What does it do ?

Inline all sources. Example Gateway source

func NewGatewayTCPRouteSource(ctx context.Context, clients ClientGenerator, config *Config) (Source, error) {

Motivation

Should help to simplify support for sources

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from szuecs January 1, 2026 13:21
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 1, 2026
@coveralls
Copy link

coveralls commented Jan 1, 2026

Pull Request Test Coverage Report for Build 20639523127

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 489 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.03%) to 78.772%

Files with Coverage Reduction New Missed Lines %
skipper_routegroup.go 3 39.34%
node.go 9 92.37%
pod.go 9 95.24%
istio_gateway.go 17 89.2%
f5_transportserver.go 17 76.92%
ingress.go 18 88.6%
crd.go 18 67.68%
f5_virtualserver.go 19 78.79%
openshift_route.go 20 84.06%
ambassador_host.go 21 82.43%
Totals Coverage Status
Change from base Build 20636734136: -0.03%
Covered Lines: 15782
Relevant Lines: 20035

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants