Skip to content

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Jan 1, 2026

What does it do ?

Remove cloudfoundry support

It was added in 2018 #955

No documentation, no updates since 2018. I was using Cloudfoundry years back. Not sure what exactly this code should support. Basically cloudfoundry does not require external-dns, and is a different platform.

Most recent cloudfoundry is very much integrated with Kubernetes https://www.cloudfoundry.org/technology/korifi/, and it does support ingress, service and etc, so does not require anything specific.

Motivation

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from vflaux January 1, 2026 13:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 1, 2026
@ivankatliarchuk ivankatliarchuk force-pushed the chore-remove-cloudfoundry-source branch from e3113a0 to 16f05cd Compare January 1, 2026 13:37
@coveralls
Copy link

coveralls commented Jan 1, 2026

Pull Request Test Coverage Report for Build 20639496252

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 71 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 78.801%

Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 84.29%
store.go 70 40.78%
Totals Coverage Status
Change from base Build 20636734136: 0.002%
Covered Lines: 15776
Relevant Lines: 20020

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants