Skip to content

Conversation

@elevran
Copy link
Contributor

@elevran elevran commented Nov 20, 2025

What type of PR is this?
/kind deprecation

What this PR does / why we need it:
Defining a metric port via CLI conflicts with use of multiport inference pool and/or changes to inference-pool at runtime (see #1396 and #1398).

Which issue(s) this PR fixes:
Fixes #1398
Fixes #1396

Does this PR introduce a user-facing change?:

The EPP `--model-server-metrics-port` CLI option is being deprecated and shall be removed in an upcoming release.

@k8s-ci-robot k8s-ci-robot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Nov 20, 2025
@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 0328e4a
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6923002be438ca000872a2a3
😎 Deploy Preview https://deploy-preview-1886--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elevran
Once this PR has been reviewed and has the lgtm label, please assign nirrozenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2025
@elevran elevran force-pushed the deprecate_inference_server_metrics_port_cli branch from 3bb2092 to 0328e4a Compare November 23, 2025 12:38
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 23, 2025
@nirrozenbaum
Copy link
Contributor

Thanks @elevran.

/lgtm

leaving final stamp to @kfswain or @ahg-g to make sure we don't miss anything here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support changing InferencePool port at runtime? InferencePool port specification (e.g., serving, metrics and health)

3 participants