Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor codegen scripts to make it easier to generate two clients #3589

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor codegen scripts to make it easier to generate two clients #3589

wants to merge 4 commits into from

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Feb 3, 2025

This simplifies the ListenerSet APIs PR

#3588

Release Note

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2025
@dprotaso dprotaso mentioned this pull request Feb 3, 2025
Open
@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 3, 2025

note - the order of the versions is changed in the clients because of it's the order (from find) inputted into client-gen

@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 4, 2025

This is ready

@shaneutt shaneutt self-assigned this Feb 6, 2025
@shaneutt shaneutt requested review from shaneutt and mlavacca February 6, 2025 15:53
shaneutt
shaneutt requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dprotaso!

Could you please expand the description of the PR to cover in more detail the specific problems that this fixes?

cmd/modelschema/main.go Show resolved Hide resolved
hack/update-clientset.sh Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dprotaso
Once this PR has been reviewed and has the lgtm label, please ask for approval from shaneutt. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt requested changes

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

@mlavacca mlavacca Awaiting requested review from mlavacca

Assignees

@shaneutt shaneutt

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @k8s-ci-robot @shaneutt