GEP-713 enhancements #3609
+1,130
−905
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,24 +1,22 @@ | ||||||
| # GEP-2649: Inherited Policy Attachment | ||||||
|
|
||||||
| * Issue: [#2649](https://github.com/kubernetes-sigs/gateway-api/issues/2649) | ||||||
| * Status: Declined | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| (See [status definitions](../overview.md#gep-states).) | ||||||
|
|
||||||
| ## TLDR | ||||||
|
|
||||||
| !!! warning | ||||||
| This GEP has been merged back into [GEP-713](https://gateway-api.sigs.k8s.io/geps/gep-713/) | ||||||
| and now it's now obsolete. Please refer the original specification of Metaresources | ||||||
| and Policy Attachment for the current state of the pattern. | ||||||
|
|
||||||
| Describe and specify a design pattern for a class of metaresource that can | ||||||
| affect specific settings across a multiple target objects. | ||||||
|
|
||||||
| This is a design for a _pattern_, not an API field or new object. | ||||||
|
|
||||||
| ## Goals | ||||||
|
|
||||||
| * Specify what common properties all Inherited Policies MUST have | ||||||
|
|
@@ -224,7 +222,7 @@ proposal](https://github.com/kubernetes-sigs/gateway-api/issues/611). | |||||
|
|
||||||
| ### Policy Attachment for Ingress | ||||||
| When talking about Direct Attached Policy attaching to Gateway resources for | ||||||
| ingress use cases (as discussed in GEP-2648), the flow is relatively | ||||||
| straightforward. A policy can reference the resource it wants to apply to, and | ||||||
| only affects that resource. | ||||||
|
|
||||||
|
|
@@ -245,7 +243,7 @@ namespaces. | |||||
|  | ||||||
|
|
||||||
| In this example, the Gateway has a TimeoutPolicy attached, which affects the | ||||||
| HTTPRoute in the App namespace. That HTTPRoute also has the Direct Attached | ||||||
| RetryPolicy attached, which affects the HTTPRoute itself, and one of the backends | ||||||
| has a HealthCheckPolicy attached to the Service, which is also a Direct Attached | ||||||
| Policy. | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,15 +2,15 @@ apiVersion: internal.gateway.networking.k8s.io/v1alpha1 | |||||
| kind: GEPDetails | ||||||
| number: 2649 | ||||||
| name: Inherited Policy Attachment | ||||||
| status: Declined | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||||
| authors: | ||||||
| - youngnick | ||||||
| - robscott | ||||||
| relationships: | ||||||
| obsoletedBy: | ||||||
| - name: Metaresources and Policy Attachment | ||||||
| number: 713 | ||||||
| description: Merged back into the original spec for Metaresources and Policy Attachment where it's presented as a well-defined class of metaresource | ||||||
| # references is a list of hyperlinks to relevant external references. | ||||||
| # It's intended to be used for storing GitHub discussions, Google docs, etc. | ||||||
| references: | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
Declinedwas suggested before. OK withReplacedinstead, @youngnick?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with
Replacedit conveys the message well enough, and then they can see the warning in thetldrfor more details.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced is fine.