conformance: allow passing GatewayStaticAddresses from CLI #4234
Conversation
Otherwise it cannot be passed as these options are required
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
area/conformance-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
|
Required for what? more context? |
|
@howardjohn: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
the test needs these set. You can only set them if you call the conformance test from your own custom go test, instead of |
| var usable, unusable []v1beta1.GatewaySpecAddress | ||
| if v := *flags.UsableAddress; v != "" { | ||
| usable = append(usable, v1beta1.GatewaySpecAddress{ | ||
| Type: ptr.To(v1beta1.HostnameAddressType), |
There was a problem hiding this comment.
Why is this hardcoded to hostname type?
4 participants
Otherwise it cannot be passed as these options are required
What type of PR is this?
/area conformance-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: