Skip to content

feat: Add NodeOverlay Validation Controller #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jun 13, 2025

Fixes #N/A

Description

This PR introduces a new validation controller for NodeOverlay resources in Karpenter. The controller ensures that NodeOverlay resources with the same weight don't have conflicting configurations, which could lead to inconsistent node behavior.

Implemented NodeOverlay conflict detection: #2166

Key features:

  • Validates that NodeOverlays with the same weight and overlapping requirements don't have conflicting price adjustments
  • Validates that NodeOverlays with the same weight and overlapping requirements don't have conflicting capacity settings for the same resources
  • Sets appropriate validation status conditions on NodeOverlay resources
  • Includes comprehensive test coverage for various validation scenarios

The validation controller helps maintain consistency across NodeOverlay resources by preventing configurations that could lead to ambiguous behavior when multiple overlays apply to the same node. This ensures that when multiple NodeOverlays match a node, they don't attempt to apply conflicting modifications.

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: engedaam
Once this PR has been reviewed and has the lgtm label, please assign jmdeal for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 13, 2025
@engedaam engedaam force-pushed the add-nodeoverlay-validation-controller branch 2 times, most recently from 24a6504 to 82c6f61 Compare June 13, 2025 01:31
@engedaam engedaam force-pushed the add-nodeoverlay-validation-controller branch from 82c6f61 to dc397d7 Compare June 13, 2025 02:02
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants