test: allow e2e tests to output junit report #2334
Conversation
Signed-off-by: Max Cao <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maxcao13 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
| @@ -41,12 +41,14 @@ apply-with-kind: verify build-with-kind ## Deploy the kwok controller from the c | |||
| --set-string controller.env[0].name=ENABLE_PROFILING \ | |||
| --set-string controller.env[0].value=true | |||
|
|
|||
| JUNIT_REPORT := $(if $(ARTIFACT_DIR), --ginkgo.junit-report="$(ARTIFACT_DIR)/junit_report.xml") | |||
There was a problem hiding this comment.
Can we make this conditional? Only get the report when we have an ENV
There was a problem hiding this comment.
Thanks for the review.
Sorry if the code is not clear, or I am misinterpreting you but I think the line is already conditional?
The $(if ...) function sets the JUNIT_REPORT variable to the --ginkgo.junit-report flag only when the ARTIFACT_DIR environment variable is defined, otherwise it will just be an empty string and not affect the full go test command.
Fixes #N/A
Description
Adds the ability to specify
ARTIFACT_DIRin theMakefilewhich allows e2e tests to output ajunit_report.xmlfile to it, ifARTIFACT_DIRis specified.How was this change tested?
Running
on a kind cluster with all prerequisite steps (
make install-kwok,make apply-with-kind, etc.).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.