-
Notifications
You must be signed in to change notification settings - Fork 297
fix: pod errors when nodepool requirements filter all instance types #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rschalo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 16059149055Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Fixes #N/A
Description
When NodeClaimTemplates are generated for the scheduling code, if NodePool requirements filter out all instance types then zero NodeClaimTemplates will be used for the
parallelizeUntil
call in the scheduler code. It's still important for Karpenter to ack the pods if the pods can schedule to existing or in-flight capacity, so after those checks if zero NodeClaimTemplates exist, a default error is sent back for the pod via podErrors.How was this change tested?
Expanded unit testing and make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.