-
Notifications
You must be signed in to change notification settings - Fork 388
fix: Update label for deleted node #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @SwechchhaSinha! |
|
Hi @SwechchhaSinha. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SwechchhaSinha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: Change the label added on the deleted node
Description
When a node is marked to be deleted by Karpenter, the label value for Kubernetes exclude from loadbalancers is set to karpenter, instead of usual value of true. This causes the node to become a part of the load balancer group.
How was this change tested?
Update the change in our forked repository and soaked and tested.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.