Skip to content

Conversation

@olyazavr
Copy link

Description
We've been seeing slow lease updates in our very loaded clusters that lead to a ton of container restarts. We've made changes to relax the lease settings on other kube components, but I found no such settings available for karpenter.

This adds 3 configurable flags/env vars to control leader election:

  • lease duration: leader-election-lease-duration, LEADER_ELECTION_LEASE_DURATION, default 15s
  • renew deadline: leader-election-renew-deadline, LEADER_ELECTION_RENEW_DEADLINE, default 10s
  • retry period: leader-election-retry-period, LEADER_ELECTION_RETRY_PERIOD, default 2s

Defaults are taken from the controller defaults, so no change to existing behavior. Descriptions are copied from other kube components with these settings.

How was this change tested?
I deployed this patch into our own cluster with extra logging to ensure the (higher than default) values were taken and verified that the slow lease updates and sporadic container restarts went away

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: olyazavr / name: Olga Shestopalova (2936362)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olyazavr
Once this PR has been reviewed and has the lgtm label, please assign jonathan-innis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @olyazavr!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @olyazavr. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2025
@olyazavr olyazavr force-pushed the leader-election-lease-config branch from ae863a0 to 0d2d637 Compare November 20, 2025 15:05
@olyazavr olyazavr force-pushed the leader-election-lease-config branch from 0d2d637 to 2936362 Compare November 20, 2025 15:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 20, 2025
@coveralls
Copy link

coveralls commented Nov 20, 2025

Pull Request Test Coverage Report for Build 19541428786

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 81.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 3 0.0%
Totals Coverage Status
Change from base Build 19342868454: 0.005%
Covered Lines: 11794
Relevant Lines: 14542

💛 - Coveralls

@k8s-ci-robot
Copy link
Contributor

@olyazavr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants