Skip to content

Enable conversion webhooks for v1beta2 (LocalQueue & ClusterQueue & Workload) #7318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enable conversion webhooks for v1beta2 (LocalQueue & ClusterQueue & Workload) #7318

wants to merge 6 commits into from
+3,593 −148

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 20, 2025 •
edited
Loading

What type of PR is this?

/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #7113

Special notes for your reviewer:

This introduces just a subset of conversions, but we could consider merging this already so that the future diffs are easier to comprehend. Adding more conversions will not change the approach hopefully.

Not adding any release notes because we already have in the previous PR introducing v1beta2. We will also refine the release notes at the end of the migration process.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 20, 2025
@netlify Netlify
Copy link

netlify bot commented Oct 20, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 4c53118
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68f75c5f06071d0008a40790

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 20, 2025
@mimowo mimowo force-pushed the v1beta2-with-crds-update branch 2 times, most recently from c178cd0 to 032a85a Compare October 20, 2025 08:03
@mimowo mimowo changed the title Enable conversion webhooks for v1beta2 WIP: Enable conversion webhooks for v1beta2 Oct 20, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
@mimowo mimowo force-pushed the v1beta2-with-crds-update branch 2 times, most recently from 09652ef to f425a2f Compare October 20, 2025 09:25
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2025
@mimowo mimowo force-pushed the v1beta2-with-crds-update branch 6 times, most recently from 64c3260 to 87efe2c Compare October 20, 2025 12:03
@mimowo
Copy link
Contributor Author

mimowo commented Oct 20, 2025

/test pull-kueue-test-integration-baseline-main
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/7318/pull-kueue-test-integration-baseline-main/1980243581536833536
seems like a flake

@mimowo mimowo changed the title WIP: Enable conversion webhooks for v1beta2 Enable conversion webhooks for v1beta2 Oct 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Oct 20, 2025

cc @tenzen-y

@mimowo mimowo changed the title Enable conversion webhooks for v1beta2 Enable conversion webhooks for v1beta2 (LocalQueue & ClusterQueue) Oct 20, 2025
@mimowo mimowo force-pushed the v1beta2-with-crds-update branch from 87efe2c to 7d6a769 Compare October 20, 2025 13:07
@mimowo
Copy link
Contributor Author

mimowo commented Oct 20, 2025

cc @mbobrovskyi ptal

@mimowo
Copy link
Contributor Author

mimowo commented Oct 20, 2025

/test pull-kueue-test-e2e-main-1-34
infra failure: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/7318/pull-kueue-test-e2e-main-1-34/1980259608379265024

@mbobrovskyi
Copy link
Contributor

/lgtm
Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5797ddef8abb5814ed2679187df6124e0bb8ae03

@mbobrovskyi
Copy link
Contributor

/hold if @tenzen-y have some comments

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@mimowo mimowo force-pushed the v1beta2-with-crds-update branch from 7d6a769 to 26d1f29 Compare October 20, 2025 16:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mimowo
Copy link
Contributor Author

mimowo commented Oct 20, 2025

rebased

@mimowo mimowo force-pushed the v1beta2-with-crds-update branch from 26d1f29 to 87461c0 Compare October 20, 2025 18:47
@mimowo mimowo changed the title Enable conversion webhooks for v1beta2 (LocalQueue & ClusterQueue) Enable conversion webhooks for v1beta2 (LocalQueue & ClusterQueue & Workload) Oct 20, 2025
@mimowo mimowo force-pushed the v1beta2-with-crds-update branch from 87461c0 to 9d1777b Compare October 20, 2025 18:51
@mimowo mimowo force-pushed the v1beta2-with-crds-update branch from 9d1777b to 6d56445 Compare October 20, 2025 19:01
@mimowo
Copy link
Contributor Author

mimowo commented Oct 20, 2025

/test pull-kueue-test-e2e-customconfigs-main
looks like unrelated flake

@k8s-ci-robot
Copy link
Contributor

@mimowo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-e2e-customconfigs-main 4c53118 link true /test pull-kueue-test-e2e-customconfigs-main
pull-kueue-test-e2e-main-1-32 4c53118 link true /test pull-kueue-test-e2e-main-1-32
pull-kueue-test-e2e-main-1-31 4c53118 link true /test pull-kueue-test-e2e-main-1-31
pull-kueue-test-e2e-main-1-33 4c53118 link true /test pull-kueue-test-e2e-main-1-33
pull-kueue-test-e2e-main-1-34 4c53118 link true /test pull-kueue-test-e2e-main-1-34

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@mbobrovskyi mbobrovskyi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mimowo @k8s-ci-robot @mbobrovskyi