[flaky integration test] Scheduler when ClusterQueue head has inadmissible workload sticky workload deleted, next workload can admit

[pajakd]

What type of PR is this?

/kind cleanup
/kind flake

What this PR does / why we need it:

It deflakes an integration test (analysis of the flaking scenario).

It is safer to use the FinishEvictionOfWorkloadsInCQ instead of FinishEvictionsOfAnyWorkloadsInCq because the former is waiting in the Eventually block for the workloads to become ready for eviction.

Also, the ExpectMetric util functions are calling an Eventually inside them. So it makes no sense to have the enclosing Eventually.

Updated two tests. Tested by running >100 times in a loop.

Which issue(s) this PR fixes:

Fixes #7250

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	e9bfdce
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68f623c5677a060008a0432e
😎 Deploy Preview	https://deploy-preview-7325--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[mimowo]

/lgtm
/approve
/cherrypick release-0.14
/cherrypick release-0.13

[k8s-infra-cherrypick-robot]

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.13, release-0.14 in new PRs and assign them to you.

In response to this:

/lgtm
/approve
/cherrypick release-0.14
/cherrypick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4287079d94f7e6cb3eb9531334c9c98fdd2bb7d9

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, pajakd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mimowo]

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/7325/pull-kueue-test-e2e-main-1-31/1980248809606746112
seems like a flake unrelated, I also saw it recently on my branch
opened: #7326

[mimowo]

/test pull-kueue-test-e2e-main-1-31

[k8s-infra-cherrypick-robot]

@mimowo: new pull request created: #7327

In response to this:

/lgtm
/approve
/cherrypick release-0.14
/cherrypick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@mimowo: #7325 failed to apply on top of branch "release-0.13":

Applying: Deflake test
Using index info to reconstruct a base tree...
M	test/integration/singlecluster/scheduler/fairsharing/fair_sharing_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/integration/singlecluster/scheduler/fairsharing/fair_sharing_test.go
CONFLICT (content): Merge conflict in test/integration/singlecluster/scheduler/fairsharing/fair_sharing_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Deflake test

In response to this:

/lgtm
/approve
/cherrypick release-0.14
/cherrypick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.