fix: comments the boilerplate in the helm chart #7329
Conversation
k8s-ci-robot
added
kind/bug
|
|
k8s-ci-robot
added
the
cncf-cla: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bobsongplus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @bobsongplus. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Signed-off-by: song <[email protected]>
bobsongplus
force-pushed
the
comment-boilerplate-in-helm-chart
branch
from
7df9aa9 to
4a9ba26
Compare
k8s-ci-robot
added
cncf-cla: yes
| outputPath := filepath.Join(fileOps.OutputDir, filepath.Base(fileOps.Path)) | ||
|
|
||
| prefix := []byte(fmt.Sprintf("{{/* Code generated by %s. DO NOT EDIT. */}}\n\n", filepath.Base(os.Args[0]))) | ||
| prefix := []byte(fmt.Sprintf("# {{/* Code generated by %s. DO NOT EDIT. */}}\n\n", filepath.Base(os.Args[0]))) |
There was a problem hiding this comment.
I don't think that this is needed since this is already handled as Helm Chart comments.
Can you share reproduce step where you can not install Helm chart to your cluster?
There was a problem hiding this comment.
you are right. I will close this PR.
3 participants
What type of PR is this?
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
Remove the boilerplate at the top of the Helm chart YAML. The chart cannot be installed until the first line of boilerplate is removed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?