fix: remove deprecated `commonLabels` by chansuke · Pull Request #5965 · kubernetes-sigs/kustomize

chansuke · 2025-08-19T09:26:10Z

replace deprecated commonLabels with labels

the following files were intentionally unchanged:

examples/transformerconfigs/README.md // the documentation of transformer
site/content/ // API reference document
examples/alphaTestExamples/helloapp.md // alpha test example
examples/zh/ // Chinese translation (out of scope)
test files that needed for backwards compatibility testing

k8s-ci-robot · 2025-08-19T09:26:12Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2025-08-19T09:26:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-08-19T09:46:08Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sarab97 · 2025-08-19T16:19:14Z

/lgtm

k8s-ci-robot · 2025-08-19T16:19:19Z

@sarab97: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

api/krusty/testdata/localize/remote/kustomization.yaml

koba1t · 2025-08-21T04:35:16Z

Hi @chansuke

Thanks for your help!
I added one comment, please check that.

By the way, I think we're still using deprecated fields in our official docs.
Could you fix those too?
https://github.com/kubernetes-sigs/cli-experimental/tree/master/site

chansuke · 2025-08-22T08:11:06Z

@koba1t
Thank you so much for your review!! Yes, I will handle this too:)

examples/configureBuiltinPlugin.md

examples/helloWorld/kustomization.yaml

stormqueen1990 · 2025-09-14T21:03:56Z

/uncc

koba1t

Thanks for your work!
I've added a few more comments. Please check them.

koba1t · 2025-09-20T15:04:08Z

examples/helloWorld/README.md

-  variant: staging
-  org: acmeCorporation
+labels:
+- includeSelectors: true


Looks like includeSelectors was removed from examples/helloWorld/kustomization.yaml.
Do you have any reason to still remain?

koba1t · 2025-09-20T15:04:15Z

examples/helloWorld/README.md

-  variant: production
-  org: acmeCorporation
+labels:
+- includeSelectors: true


koba1t · 2025-09-20T15:05:17Z

examples/transformerconfigs/crd/kustomization.yaml

-commonLabels:
-  foo: bar
+labels:
+- includeSelectors: true


koba1t · 2025-09-20T15:09:23Z

examples/transformerconfigs/crd/kustomization.yaml


-commonLabels:
-  foo: bar
+labels:


This example modifies the behavior of commonLabels in the transformer configuration.
If you modify this section, also update the README.md to instruct users to configure the labels transformer accordingly.

If you don't know how to change the contents of this section, it's fine to keep it as is.

k8s-triage-robot · 2025-12-19T15:23:36Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2026-01-18T21:13:18Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2026-02-17T21:14:11Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2026-02-17T21:14:17Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2025

k8s-ci-robot requested review from stormqueen1990 and varshaprasad96 August 19, 2025 09:26

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2025

chansuke force-pushed the fix/remove-deprecated-commonlabels branch from 7602368 to c0b26cc Compare August 19, 2025 09:46

chansuke marked this pull request as ready for review August 19, 2025 11:02

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2025

k8s-ci-robot requested a review from koba1t August 19, 2025 11:02

koba1t requested changes Aug 21, 2025

View reviewed changes

api/krusty/testdata/localize/remote/kustomization.yaml Outdated Show resolved Hide resolved

chansuke force-pushed the fix/remove-deprecated-commonlabels branch from d320ac3 to 0424a19 Compare August 23, 2025 15:57

chansuke mentioned this pull request Aug 23, 2025

fix: replace deprecated commonlabels kubernetes-sigs/cli-experimental#419

Open

chansuke requested a review from koba1t August 24, 2025 01:31

koba1t added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 24, 2025

koba1t requested changes Aug 24, 2025

View reviewed changes

examples/configureBuiltinPlugin.md Show resolved Hide resolved

koba1t reviewed Aug 24, 2025

View reviewed changes

examples/helloWorld/kustomization.yaml Outdated Show resolved Hide resolved

chansuke requested a review from koba1t August 25, 2025 14:45

k8s-ci-robot removed the request for review from stormqueen1990 September 14, 2025 21:03

koba1t requested changes Sep 20, 2025

View reviewed changes

koba1t mentioned this pull request Oct 19, 2025

Fix kustomization fields #5996

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2025

chansuke added 4 commits December 20, 2025 00:58

fix: remove deprecated commonLabels

2e23a2e

fix: remove unnecessary includeSelectors

dc16983

fix: remove includeLabels from HPA

d9effa3

fix: remove includeLabels

22f0179

chansuke force-pushed the fix/remove-deprecated-commonlabels branch from 6e4f433 to 22f0179 Compare December 19, 2025 15:58

fix: update README

fb3e7d5

chansuke requested a review from koba1t December 19, 2025 20:32

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 18, 2026

k8s-ci-robot closed this Feb 17, 2026

Conversation

chansuke commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

sarab97 commented Aug 19, 2025

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

Uh oh!

koba1t commented Aug 21, 2025

Uh oh!

chansuke commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

stormqueen1990 commented Sep 14, 2025

Uh oh!

koba1t left a comment

Choose a reason for hiding this comment

Uh oh!

koba1t Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

koba1t Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

koba1t Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

koba1t Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Dec 19, 2025

Uh oh!

k8s-triage-robot commented Jan 18, 2026

Uh oh!

k8s-triage-robot commented Feb 17, 2026

Uh oh!

k8s-ci-robot commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chansuke commented Aug 19, 2025 •

edited

Loading