fix: support helm v4 beside v3

[hmilkovi]

This PR fixes Helm V4 issues.

Helm V4 is backward compatible with V3 helm charts and -c is not needed for V3 Helm (tested it).

This is fix for error I experience also #6013

Many thanks in advance for viewing this PR.

[k8s-ci-robot]

Welcome @hmilkovi!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: hmilkovi / name: Hrvoje Milković (1bd4b8a, 2c08792, 4e9df75, 8032c9f, e9d8310, f61cc1c)

[k8s-ci-robot]

Hi @hmilkovi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hmilkovi]

I have changed tests to be done with V4. I was thinking if I should implement to run tests with both versions of Helm?

[koba1t]

Considering that Helm v3 is likely installed in the environment, I believe we need code and tests that can support both v3 and v4 environments.

[koba1t]

/ok-to-test

[koba1t]

Helm V4 is backward compatible with V3 helm charts and -c is not needed for V3 Helm (tested it).

OK, I understand.
Please add tests for both v3 and v4 binaries.
This ensures backward compatibility in kustomize.

[hmilkovi]

I agree as I didn't want to make it only Helm V4 as many people will still use V3 and that would be a breaking change.

I have added wrapper for Helm tests to be run for multiple versions in HelmChartInflationGenerator_test.go, example test logs:

--- PASS: TestHelmChartInflationGeneratorWithDebug (0.48s)
    --- PASS: TestHelmChartInflationGeneratorWithDebug/HelmV3 (0.24s)
    --- PASS: TestHelmChartInflationGeneratorWithDebug/HelmV4 (0.24s)

[hmilkovi]

/retest

[hmilkovi]

/retest-required

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hmilkovi, Skaronator
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment