Add support for master and garbage collector pod topology spread constraints by solidDoWant · Pull Request #1955 · kubernetes-sigs/node-feature-discovery

solidDoWant · 2024-11-11T22:51:05Z

This adds topologySpreadConstraints fields to the master and garbage collector pods via the Helm chart.

…traints Signed-off-by: Fred Heinecke <fred.heinecke@yahoo.com>

linux-foundation-easycla · 2024-11-11T22:51:08Z

❌ - login: @solidDoWant . The commit (6c60901) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

k8s-ci-robot · 2024-11-11T22:51:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: solidDoWant
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-11-11T22:51:13Z

Welcome @solidDoWant!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-11-11T22:51:14Z

Hi @solidDoWant. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-11-11T22:51:19Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`6c60901`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67489a2ac393d200089aeb0b
😎 Deploy Preview	https://deploy-preview-1955--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

solidDoWant · 2024-11-11T22:52:49Z

Hey folks I agree to the terms and conditions in the CLA but I'm not going to provide my full name, email, and physical address to submit a minor 13 line feature to this project.

Do whatever you want with this PR and the code I have submitted in it, but I will not be signing the CLA due to privacy concerns.

marquiz

Thank you @solidDoWant for the improvement

Could you sign the CLA (in addition to addressing the one review comment below) so that we could proceed with the PR?

marquiz · 2024-11-28T14:46:32Z

deployment/helm/node-feature-discovery/templates/nfd-gc.yaml

        {{- toYaml . | nindent 8 }}
    {{- end }}
+      {{- with .Values.gc.topologySpreadConstraints }}
+      tolerations:


tolerations??

Sorry - fixed this but forgot to push.

solidDoWant · 2024-11-28T16:29:27Z

Could you sign the CLA

#1955 (comment)

marquiz · 2024-11-29T08:44:31Z

Hey folks I agree to the terms and conditions in the CLA but I'm not going to provide my full name, email, and physical address to submit a minor 13 line feature to this project.

Do whatever you want with this PR and the code I have submitted in it, but I will not be signing the CLA due to privacy concerns.

Oh, sorry to hear that 😢 Unfortunately it's a requirement for kubernetes projects to have the CLA signed before accepting contributions

k8s-triage-robot · 2025-02-27T09:09:16Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-03-29T09:13:14Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-04-28T09:44:46Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-04-28T09:44:51Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Add support for master and garbage collector pod topology spread cons…

6c60901

…traints Signed-off-by: Fred Heinecke <fred.heinecke@yahoo.com>

k8s-ci-robot requested review from PiotrProkop and marquiz November 11, 2024 22:51

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 11, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2024

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2024

marquiz reviewed Nov 28, 2024

View reviewed changes

solidDoWant force-pushed the master branch from 7a7e7bb to 6c60901 Compare November 28, 2024 16:28

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 29, 2025

k8s-ci-robot closed this Apr 28, 2025

Conversation

solidDoWant commented Nov 11, 2024

Uh oh!

linux-foundation-easycla bot commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Nov 11, 2024

Uh oh!

k8s-ci-robot commented Nov 11, 2024

Uh oh!

k8s-ci-robot commented Nov 11, 2024

Uh oh!

netlify bot commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Uh oh!

solidDoWant commented Nov 11, 2024

Uh oh!

marquiz left a comment

Choose a reason for hiding this comment

Uh oh!

marquiz Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

solidDoWant Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

solidDoWant commented Nov 28, 2024

Uh oh!

marquiz commented Nov 29, 2024

Uh oh!

k8s-triage-robot commented Feb 27, 2025

Uh oh!

k8s-triage-robot commented Mar 29, 2025

Uh oh!

k8s-triage-robot commented Apr 28, 2025

Uh oh!

k8s-ci-robot commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linux-foundation-easycla bot commented Nov 11, 2024 •

edited

Loading

netlify bot commented Nov 11, 2024 •

edited

Loading